Rotation with zip leaved file descriptors open (on Windows)

[Apollon77]

I have reports that on Windows it seems that file descriptors are not correctly closed for the "oldFile" when packing, see ioBroker/ioBroker.js-controller#578

My assumption is that in https://github.com/winstonjs/winston-daily-rotate-file/blob/master/daily-rotate-file.js#L120 the ReadStream stays open somehow ...

I currently have one use testing if an explicite "inp.destroy()" helps ... if yes I will create an PR

[Apollon77]

Ok, Test result is as "expected": It seems that the ReadStream never finshes on windows and thats why the old logfile stays as well as the gz one ... as soon as the process ends all of this finishes because gets closed.

So the explicit "destroy" has no effect because gets never called.

Now the question is: why

[Apollon77]

maybe it is in file-stream-rotator?
They end the stream (https://github.com/rogerc/file-stream-rotator/blob/master/FileStreamRotator.js#L590) but maybe emit rotate BEFORE the stream ended.

I will test tomorrow if it is better to emit the "rotate" event in the callback from "end" of the old stream ...

[Apollon77]

Also that change had no effect.

So it seems that on WIndows the "Readstream" when file is packaged never ends, and so both file descriptirs (unpacked and gz) stay open until the nodejs process gets stopped.

[mattberther]

@Apollon77 Is this still an issue, or have your other PRs addressed this?

[Apollon77]

No still an issue and I have no idea how to dive I to this because I‘m no Windows User :-( I just got this as User problems and and we then analyzed it down to this description above

[mattberther]

I'm not a Windows user either, and so will need to keep open to see if someone from the community can help with this.

[Apollon77]

@mattberther Maybe add a "help needed" label or such?