Skip to content

Commit 3c47983

Browse files
moliholytomako
authored andcommitted
PROVISIONAL Fix surface catalog list validation error blocking save
Source repo: moliholy:fix/catalog-save-validation-feedback af95bca Applied on: PROVISIONAL Affiliation-extras plugin: add Affiliation Catalogs (indico#6)
1 parent ffe3122 commit 3c47983

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

affiliation_extras/indico_affiliation_extras/client/catalogs/CatalogDetailPane.jsx

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ import _ from 'lodash';
99
import PropTypes from 'prop-types';
1010
import React from 'react';
1111
import {DndProvider} from 'react-dnd';
12-
import {Form as FinalForm} from 'react-final-form';
12+
import {Form as FinalForm, FormSpy} from 'react-final-form';
1313
import {HTML5Backend} from 'react-dnd-html5-backend';
14-
import {Form, Segment} from 'semantic-ui-react';
14+
import {Form, Message, Segment} from 'semantic-ui-react';
1515

1616
import {ManagementPageSubTitle} from 'indico/react/components';
1717
import {FinalInput, FinalSubmitButton} from 'indico/react/forms';
@@ -91,6 +91,14 @@ export default function CatalogDetailPane({catalog, targetLocator, isNew, onSubm
9191
</h3>
9292
<FinalCatalogList name="lists" targetLocator={targetLocator} required />
9393
</section>
94+
<FormSpy subscription={{errors: true, dirty: true}}>
95+
{({errors, dirty}) =>
96+
dirty && errors.lists ? (
97+
// `negative` (not `error`): Semantic hides `.error.message` inside a Form
98+
<Message negative size="small" content={errors.lists} />
99+
) : null
100+
}
101+
</FormSpy>
94102
<div styleName="form-actions">
95103
<FinalSubmitButton label={Translate.string('Save changes')} disabledUntilChange />
96104
</div>

0 commit comments

Comments
 (0)