Merge pull request #874 from wireapp/remove-oboslete-secrets

Remove obsolete secrets from the brig config

Author: sghosh23

bin/offline-secrets.sh

@@ -53,12 +53,7 @@ brig:
       password: guest
     # These are only necessary if you wish to support sign up via SMS/calls
     # And require accounts at twilio.com / nexmo.com
-    setTwilio: |-
-      sid: "dummy"
-      token: "dummy"
-    setNexmo: |-
-      key: "dummy"
-      secret: "dummy"
+
 cargohold:
   secrets:
     awsKeyId: "$minio_cargohold_access_key"

bin/secrets.sh

@@ -104,14 +104,7 @@ brig:
         # these only need to be changed if using real AWS services
         awsKeyId: dummykey
         awsSecretKey: dummysecret
-        # These are only necessary if you wish to support sign up via SMS/calls
-        # And require accounts at twilio.com / nexmo.com
-        setTwilio: |-
-            sid: dummy
-            token: dummy
-        setNexmo: |-
-            key: dummy
-            secret: dummy
+
 cargohold:
     secrets:
         awsKeyId: dummykey

changelog.d/3-deploy-builds/remove-oboslete-secrets

@@ -0,0 +1 @@
+Removed: obsolete secrets from scripts and references for improved security and clarity.

values/wire-server/demo-secrets.example.yaml

@@ -28,12 +28,6 @@ brig:
     # To extract the secret from an existing Kubernetes cluster:
     #   kubectl get secret wire-postgresql-secret -n postgresql -o jsonpath='{.data.password}' | base64 -d
     pgPassword: dummyPassword # gets replaced by the actual secret
-    setTwilio: |-
-      sid: "dummy"
-      token: "dummy"
-    setNexmo: |-
-      key: "dummy"
-      secret: "dummy"
     elasticsearch:
       username: "elastic"
       password: "changeme"

values/wire-server/prod-secrets.example.yaml

@@ -22,12 +22,6 @@ brig:
     rabbitmq:
       username: guest
       password: guest
-    setTwilio: |-
-      sid: "dummy"
-      token: "dummy"
-    setNexmo: |-
-      key: "dummy"
-      secret: "dummy"
 
 cannon:
   secrets: