fix(astro): handling trailingSlash config logic in Astro.originPathname

[Lofty-Brambles]

Updates the originPathname setter to respect the trailing slash configuration. Fixes #13695

Changes

• Adds simple handling logic to respect trailingSlash configuration to the setter.
• Rewrites the setter's implementations to accept the configuration options necessary, from the pipelines surrounding it.

Testing

This was tested by manually reproducing it in an environment similar to the MRE mentioned in the issue.

• An Astro project was spun up, and the local version of the package was linked.
• index.astro and my-path.astro were added and built.
• The dist had updated the originPathname to have a trailing slash.

On another note, should this also have unit tests? If so, can anyone guide me on where and what to add?

Docs

Since it is a simple internal fix, no user-facing documentation is necessary.

[changeset-bot]

🦋 Changeset detected

Latest commit: 8537607

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #13860 will not alter performance

_{Comparing Lofty-Brambles:fix/origin-path-trailing-slash (8537607) with main (442b841)}

Summary

✅ 6 untouched benchmarks

[Lofty-Brambles]

That's odd. Apparently pipeline manifest doesn't contain the config all the time? Build checks out, but this unit test fails. Any help on where to get this config then?

[florian-lefebvre]

I've pushed a fix for the unit test

[florian-lefebvre]

This needs some tests. AFAIK last time a fix about originPathname was added, a test was added in a fixture (see #13669). Maybe in this case you could create a new unit test file under test/routing?

[ematipico]

Fixed in #13997