Skip to content

[git] gitGenerators.commits doesn't handle extracting commit hash properly #2606

Description

@Tyriar

Sanity checks

  • My issue relates to a specific CLI completion spec (e.g. git checkout is missing options in git completion spec). If your issue is more general, please create your issue here: withfig/fig
  • I have searched github.com/withfig/autocomplete/issues and there are no duplicates of my issue
  • I would like to work on this.

What CLI tool does this relate to?

git

Which statement makes the most sense?

There is a bug with this completion spec

Issue Details

Commit has length of 7 is assumed but not always correct:

autocomplete/src/git.ts

Lines 119 to 137 in aef52ac

// Commit history
commits: {
script: ["git", "--no-optional-locks", "log", "--oneline"],
postProcess: function (out) {
const output = filterMessages(out);
if (output.startsWith("fatal:")) {
return [];
}
return output.split("\n").map((line) => {
return {
name: line.substring(0, 7),
icon: "fig://icon?type=node",
description: line.substring(7),
};
});
},
},

Image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions