Skip to content

Commit 9a8d925

Browse files
committed
fix(DTXTimerTrampoline): Ensure NSTimer and CADisplayLink are retained while we still need them
1 parent 3a21d1a commit 9a8d925

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

DetoxSync/DetoxSync/SyncResources/DTXTimerSyncResource.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ NS_ASSUME_NONNULL_BEGIN
2121
@property (nonatomic, assign) BOOL repeats;
2222

2323
//NSTimer
24-
@property (nonatomic, weak) NSTimer* timer;
24+
@property (nonatomic) NSTimer* timer;
2525
- (void)fire;
2626
@property (nonatomic) CFRunLoopRef runLoop;
2727

2828
//CADisplayLink
29-
@property (nonatomic, weak) CADisplayLink* displayLink;
29+
@property (nonatomic) CADisplayLink* displayLink;
3030

3131
- (void)track;
3232
- (void)untrack;

DetoxSync/DetoxSync/Utils/_DTXTimerTrampoline.m

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@ @implementation _DTXTimerTrampoline
1818
SEL _sel;
1919

2020
//NSTimer
21-
__weak NSTimer* _timer;
21+
NSTimer* _timer;
2222
CFRunLoopTimerCallBack _callback;
2323
CFRunLoopRef _runLoop;
2424
NSString* _timerDescription;
2525
NSTimeInterval _timeUntilFire;
2626

2727
//CADisplayLink
28-
__weak CADisplayLink* _displayLink;
28+
CADisplayLink* _displayLink;
2929

3030
BOOL _tracking;
3131

0 commit comments

Comments
 (0)