Skip to content

Commit 94d4d76

Browse files
committed
final PR changes
1 parent 17370e0 commit 94d4d76

7 files changed

Lines changed: 13 additions & 19 deletions

File tree

.github/workflows/release-splittext.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,14 @@ jobs:
8080
- name: Build splittext package
8181
run: yarn workspace @wix/splittext build
8282

83+
# @wix/interact is a devDependency used only by the plugin-bridge integration test —
84+
# splittext itself neither builds nor runs against it (note the build step above runs first).
85+
- name: Build motion package (test-only dependency of @wix/interact)
86+
run: yarn workspace @wix/motion build
87+
88+
- name: Build interact package (test-only dependency)
89+
run: yarn workspace @wix/interact build
90+
8391
- name: Test splittext package
8492
run: yarn workspace @wix/splittext test
8593

apps/demo/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
"dev": "vite",
88
"build": "tsc && vite build",
99
"preview": "vite preview",
10-
"lint": "tsc --noEmit",
11-
"test": "vitest run"
10+
"lint": "tsc --noEmit"
1211
},
1312
"dependencies": {
1413
"@wix/interact": "^2.5.5",

apps/demo/vitest.config.ts

Lines changed: 0 additions & 8 deletions
This file was deleted.

packages/interact/src/core/add.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -76,14 +76,7 @@ function _applyPlugins(
7676
owner._appliedPlugins.add(value);
7777
}
7878

79-
const plugin = Interact.getPlugin(name);
80-
81-
if (!plugin) {
82-
throw new Error(
83-
`Interact: config uses plugin field "${field}" but no plugin is registered under ` +
84-
`"${name}". Call Interact.use('${name}', plugin) before Interact.create().`,
85-
);
86-
}
79+
const plugin = Interact.getPlugin(name)!;
8780

8881
const cleanup = plugin(value, { root, key, scope, config });
8982

packages/splittext/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@
7676
"@types/react-dom": "^18.3.0",
7777
"@vitejs/plugin-react": "^4.3.4",
7878
"@vitest/coverage-v8": "^4.0.14",
79+
"@wix/interact": "^2.5.5",
7980
"jsdom": "^24.0.0",
8081
"react": "^18.3.1",
8182
"react-dom": "^18.3.1",

apps/demo/test/splitText.integration.spec.ts renamed to packages/splittext/test/splitText.integration.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
22
import { Interact, add, remove, generate } from '@wix/interact';
33
import type { InteractConfig } from '@wix/interact';
4-
import { splitTextPlugin, splitTextStyle } from '../src/plugins/splitText';
4+
import { splitTextPlugin, splitTextStyle } from '../src/plugin';
55

66
// End-to-end proof of the plugin bridge with the REAL @wix/splittext: splitText mutates the DOM,
77
// Interact resolves the generated spans, and disconnect reverts the split. The animation engine

yarn.lock

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1492,6 +1492,7 @@ __metadata:
14921492
"@types/react-dom": "npm:^18.3.0"
14931493
"@vitejs/plugin-react": "npm:^4.3.4"
14941494
"@vitest/coverage-v8": "npm:^4.0.14"
1495+
"@wix/interact": "npm:^2.5.5"
14951496
jsdom: "npm:^24.0.0"
14961497
react: "npm:^18.3.1"
14971498
react-dom: "npm:^18.3.1"

0 commit comments

Comments
 (0)