8.0 ios build issue

[clijiac]

Description

just build using xcode for ios. the xcode tell that

 
/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:152:5: Use of undeclared identifier 'RCTAppDelegate'

/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:152:21: Use of undeclared identifier 'appDelegate'

/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:152:51: Expected expression

/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:152:36: Use of undeclared identifier 'RCTAppDelegate'

/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:152:53: Missing '[' at start of message send expression

 /node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:152:94: Expected ']'

 /node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:153:19: Use of undeclared identifier 'appDelegate'

Steps to reproduce

just build using xcode

More Info

I think we need to add s.dependency 'React-RCTAppDelegate' into the pod file . like below

Code snippet

require 'json'

package = JSON.parse(File.read(File.join(__dir__, 'lib/package.json')))

Pod::Spec.new do |s|
  s.name         = "ReactNativeUiLib"
  s.version      = package['version']
  s.summary      = "React Native UI Library"

  s.authors      = "Wix.com"
  s.homepage     = package['homepage']
  s.license      = package['license']
  s.platforms    = { :ios => "9.0", :tvos => "9.2" }

  s.module_name  = 'ReactNativeUiLib'

  s.source       = { :git => "https://github.com/wix/react-native-ui-lib.git", :tag => "#{s.version}" }
  s.source_files  = "lib/ios/**/*.{h,m}"

  s.dependency 'React'
  s.dependency 'React-RCTAppDelegate'
  s.frameworks = 'UIKit'
end

Environment

• React Native version: 0.81.5
• React Native UI Lib version: 8.0.0

Affected platforms

• Android
• iOS
• Web

[efstathiosntonas]

this is wrong to start with, shouldn't the uilib-native be a separate package from version 8 onwards?

If you just upgrade to v8 it nags that uilib-native is missing so you got to install it.

It's duplicated between lib/ios/reactnativeuilib/ and uilib-native in node_modules.

[efstathiosntonas]

react-native-ui-lib+8.0.0.patch

diff --git a/node_modules/react-native-ui-lib/ReactNativeUiLib.podspec b/node_modules/react-native-ui-lib/ReactNativeUiLib.podspec
index aa21d9d..db01afe 100644
--- a/node_modules/react-native-ui-lib/ReactNativeUiLib.podspec
+++ b/node_modules/react-native-ui-lib/ReactNativeUiLib.podspec
@@ -18,5 +18,6 @@ Pod::Spec.new do |s|
   s.source_files  = "lib/ios/**/*.{h,m}"
 
   s.dependency 'React'
+  s.dependency 'React-RCTAppDelegate'
   s.frameworks = 'UIKit'
 end
diff --git a/node_modules/react-native-ui-lib/lib/ReactNativeUiLib.podspec b/node_modules/react-native-ui-lib/lib/ReactNativeUiLib.podspec
index d5966f8..a99fa4b 100644
--- a/node_modules/react-native-ui-lib/lib/ReactNativeUiLib.podspec
+++ b/node_modules/react-native-ui-lib/lib/ReactNativeUiLib.podspec
@@ -18,5 +18,6 @@ Pod::Spec.new do |s|
   s.source_files  = "ios/**/*.{h,m}"
 
   s.dependency 'React'
+  s.dependency 'React-RCTAppDelegate'
   s.frameworks = 'UIKit'
 end
diff --git a/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m b/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m
index 58ba154..87580ae 100644
--- a/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m
+++ b/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m
@@ -17,6 +17,8 @@
 #import <React-RCTAppDelegate/RCTAppDelegate.h>
 #elif __has_include(<React_RCTAppDelegate/RCTAppDelegate.h>)
 #import <React_RCTAppDelegate/RCTAppDelegate.h>
+#else
+#import <React/RCTAppDelegate.h>
 #endif
 
 #define kHlperViewTag 0x1f1f1f

[rohit9625]

I'm also facing this issue. Can I safely use your above patch, @efstathiosntonas?

[efstathiosntonas]

@rohit9625 been using it in production since the day I posted it above with no issues

[rohit9625]

Thanks for quick response, @efstathiosntonas. I'll proceed with your patch :)

[rohit9625]

Do I also have to install uilib-native?

[efstathiosntonas]

@rohit9625 yes, if you don't you will get console warnings

[rohit9625]

I didn't see any warnings. However, a new pod, ReactNativeUiLib 5.0.1, was installed after I applied the patch. So, are you talking about this installation or using npm?

[rohit9625]

Finally, now it builds successfully. Thanks for you help, @efstathiosntonas :)