Skip to content
/ wix Public

Comments

Append _wixcert_ to CA test for rollback check#606

Closed
bevanweiss wants to merge 1 commit intowixtoolset:mainfrom
bevanweiss:iis_append_wixcert
Closed

Append _wixcert_ to CA test for rollback check#606
bevanweiss wants to merge 1 commit intowixtoolset:mainfrom
bevanweiss:iis_append_wixcert

Conversation

@bevanweiss
Copy link
Contributor

Taken from wixtoolset/wix3/pull/546, but have left out the explicit length calculation from the pwzUniquePrefix string, and using this in the compare.

Fixes wixtoolset/issues#3976

@bevanweiss bevanweiss marked this pull request as draft February 22, 2025 13:04
@bevanweiss
Copy link
Contributor Author

I think maybe the whole _wixcert_x portion should disappear (and so this PR isn't so valid).
I believe the thumbprint of the certificate should be sufficient.
Any objections to changing to Thumbprints to know what activities we should / have already done (for the install / rollback)?

@robmen
Copy link
Member

robmen commented Mar 4, 2025

It's been a long time since I looked at the cert custom actions, but IIRC the thumbprint could be provided as a property so it wasn't necessarily a stable identifier that could be used to uninstall the certificate later. This is fuzzy, but it may be that the cert install behavior needs more of a re-design to address the suffix... which is why that issue was just hanging out unfixed.

…ength

calculation from the pwzUniquePrefix string, and using this in the compare.

Fixes #3976


Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
@robmen robmen force-pushed the main branch 5 times, most recently from adeb395 to cd5f73d Compare February 6, 2026 14:40
@standaell1234-maker

This comment was marked as spam.

@bevanweiss
Copy link
Contributor Author

I suspect that most of the parameters involved in the adding certificate into the store would be properties. FriendlyName seems likely, as does Thumbprint (both so that previously unknown certificates, like self-signed) can be added.
In which case I think it would need to store some additional information to record what was installed (unsure if this can be metadata stored into the certificate store..).
I haven't had much need for WiX stuff in my work lately unfortunately, so unlikely to get much time to dig into it.
I'll close this PR.

@bevanweiss bevanweiss closed this Feb 19, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Certificate uninstall rollback does not rollback the deletion of the certifcate

3 participants