some refactors

Author: liorschach

.circleci/tests/custom_values_charts_test.go

@@ -0,0 +1,36 @@
+package tests
+
+import (
+	"os"
+	"path"
+	"path/filepath"
+	"strings"
+)
+
+func (s *helmRepoSuite) TestChartTemplatesWithCustomValues() {
+	testFiles, err := os.ReadDir("testfiles")
+	s.NoError(err)
+
+	for _, testFile := range testFiles {
+		testFileName := testFile.Name()
+
+		s.Run(testFileName, func() {
+			chartName := strings.Split(strings.Split(testFileName, ".")[0], "_")[0]
+			chartDir := s.getChartDirectory(chartName)
+
+			chartDirFullPath, err := filepath.Abs(chartDir)
+			s.NoError(err)
+
+			valuesFilePath := path.Join("testfiles", testFileName)
+			runGoldenHelmTest(s.T(), &goldenHelmTest{
+				ChartPath: chartDirFullPath,
+				Release:   "release-test",
+				Namespace: "release-helm-namespace",
+				// remove .yaml from the test file name
+				GoldenFileName:     strings.TrimSuffix(testFileName, ".yaml"),
+				ValuesFile:         valuesFilePath,
+				GoldenSubDirectory: "custom",
+			})
+		})
+	}
+}

.circleci/tests/default_values_charts_test.go

@@ -0,0 +1,28 @@
+package tests
+
+import (
+	"path"
+	"path/filepath"
+)
+
+func (s *helmRepoSuite) TestChartTemplateWithDefaultValues() {
+	charts := s.getChartsInDirectory(chartsRootDir)
+
+	for _, chartName := range charts {
+		s.Run(chartName, func() {
+			chartDir := s.getChartDirectory(chartName)
+			chartDirFullPath, err := filepath.Abs(chartDir)
+			s.NoError(err)
+			defaultValuesFilePath := path.Join(chartDir, "values.yaml")
+
+			runGoldenHelmTest(s.T(), &goldenHelmTest{
+				ChartPath:          chartDirFullPath,
+				Release:            "release-test",
+				Namespace:          "release-helm-namespace",
+				GoldenFileName:     chartName,
+				ValuesFile:         defaultValuesFilePath,
+				GoldenSubDirectory: "default",
+			})
+		})
+	}
+}

.circleci/tests/golden.go renamed to .circleci/tests/helm_repository_suite_test.go

@@ -2,17 +2,47 @@ package tests
 
 import (
 	"flag"
+	"maps"
 	"os"
+	"path"
 	"regexp"
+	"slices"
 	"testing"
 
 	"github.com/gruntwork-io/terratest/modules/helm"
 	"github.com/gruntwork-io/terratest/modules/k8s"
 	"github.com/stretchr/testify/require"
+	"github.com/stretchr/testify/suite"
+	"helm.sh/helm/v3/pkg/chartutil"
+)
+
+const (
+	chartsRootDir = "../../."
 )
 
 var update = flag.Bool("update-golden", false, "update golden test output files")
 
+type helmRepoSuite struct {
+	suite.Suite
+}
+
+func TestHelmRepository(t *testing.T) {
+	suite.Run(t, new(helmRepoSuite))
+}
+
+func (s *helmRepoSuite) SetupSuite() {
+	// Run the helm repo add command
+	// helm repo add wiz-sec https://wiz-sec.github.io/charts
+	if _, err := helm.RunHelmCommandAndGetOutputE(s.T(), &helm.Options{}, "repo", "add", "wiz-chart-test", "https://wiz-sec.github.io/charts"); err != nil {
+		s.Failf("Failed to add helm repository", "error is %s", err)
+	}
+
+	//// Run the helm repo update command
+	if _, err := helm.RunHelmCommandAndGetOutputE(s.T(), &helm.Options{}, "repo", "update"); err != nil {
+		s.Failf("Failed to update helm repository", "error is %s", err)
+	}
+}
+
 type goldenHelmTest struct {
 	ChartPath          string
 	Release            string
@@ -64,3 +94,47 @@ func runGoldenHelmTest(t *testing.T, testCase *goldenHelmTest) {
 	r.NoError(err, "Golden file doesn't exist or was not readable")
 	r.Equal(string(expected), output, "Rendered output does not match golden file. Please run tests with -update-golden flag to update the golden files.")
 }
+
+func (s *helmRepoSuite) getChartDirectory(chartName string) string {
+	chartDir := path.Join(chartsRootDir, chartName)
+	if _, err := os.Stat(path.Join(chartDir, "Chart.yaml")); os.IsNotExist(err) {
+		//	fail the test
+		s.Fail("Chart.yaml file not found in %s", chartDir)
+	}
+
+	isChartDir, err := chartutil.IsChartDir(chartDir)
+	s.NoError(err)
+	s.True(isChartDir)
+
+	return chartDir
+}
+
+func (s *helmRepoSuite) getChartsInDirectory(dir string) []string {
+	// There's no need to add directories to this list, but this is for extra care, to ensure we don't miss these charts
+	charts := map[string]struct{}{
+		"wiz-broker":                 {},
+		"wiz-sensor":                 {},
+		"wiz-admission-controller":   {},
+		"wiz-kubernetes-connector":   {},
+		"wiz-kubernetes-integration": {},
+	}
+
+	files, err := os.ReadDir(dir)
+	s.NoError(err)
+
+	for _, fileInfo := range files {
+		if !fileInfo.IsDir() {
+			continue
+		}
+
+		chartName := fileInfo.Name()
+		chartFilePath := path.Join(path.Join(chartsRootDir, chartName), "Chart.yaml")
+		if _, err := os.Stat(chartFilePath); os.IsNotExist(err) {
+			continue
+		}
+
+		charts[chartName] = struct{}{}
+	}
+
+	return slices.Collect(maps.Keys(charts))
+}