Added sane defaults for HPA to stabilize the scaling behavior (#426)

* Added sane defaults for HPA to stabilize the scaling behavior

Author: ofirc-wiz

wiz-admission-controller/templates/_helpers.tpl

@@ -234,3 +234,18 @@ requests:
     false
   {{- end }}
 {{- end }}
+
+{{- define "wiz-admission-controller.hpaBehavior" -}}
+{{- if hasKey .Values.hpa "behavior" }}
+{{- toYaml .Values.hpa.behavior }}
+{{- else -}}
+scaleUp:
+  stabilizationWindowSeconds: 300
+scaleDown:
+  stabilizationWindowSeconds: 300
+  policies:
+  - type: Pods
+    value: 1
+    periodSeconds: 300
+{{- end -}}
+{{- end -}}

wiz-admission-controller/templates/hpa.yaml

@@ -35,10 +35,7 @@ spec:
     {{- with .Values.hpa.customMetrics }}
       {{- toYaml . | nindent 4 }}
     {{- end }}
-  {{- if hasKey .Values.hpa "behavior" }}
-  behavior:
-    {{- toYaml .Values.hpa.behavior | nindent 4 }}
-  {{- end }}
+  behavior: {{ include "wiz-admission-controller.hpaBehavior" . | nindent 4 }}
 ---
 {{- end }}
 {{ if .Values.kubernetesAuditLogsWebhook.enabled -}}
@@ -76,9 +73,6 @@ spec:
     {{- with .Values.hpa.customMetrics }}
       {{- toYaml . | nindent 4 }}
     {{- end }}
-  {{- if hasKey .Values.hpa "behavior" }}
-  behavior:
-    {{- toYaml .Values.hpa.behavior | nindent 4 }}
-  {{- end }}
+  behavior: {{ include "wiz-admission-controller.hpaBehavior" . | nindent 4 }}
 {{- end }}
 {{- end }}

wiz-admission-controller/values.yaml

@@ -437,19 +437,26 @@ probes: # Probes config for the container
 # Horizontal Pod Autoscaling.
 # Prerequisites: metrics-server installed on the cluster:
 # https://github.com/kubernetes-sigs/metrics-server
-#
 hpa:
   enabled: false
   minReplicas: 2
   maxReplicas: 5
   enableCPU: true
-  targetCPUUtilizationPercentage: 50
+  targetCPUUtilizationPercentage: 80
   enableMemory: false
-  targetMemoryUtilizationPercentage: 50
+  targetMemoryUtilizationPercentage: 80
   customMetrics: []
-  # Uncomment to customize the behavior.
-  # If not set, the default HPAScalingRules for scale up and scale down are used.
-  #behavior: {}
+  # Uncomment the `behavior` section below to specify custom scaling policies and behavior.
+  # If left blank, the following default settings are applied:
+  # behavior:
+  #   scaleUp:
+  #     stabilizationWindowSeconds: 300
+  #   scaleDown:
+  #     stabilizationWindowSeconds: 300
+  #     policies:
+  #     - type: Pods
+  #       value: 1
+  #       periodSeconds: 300
 
 # Global values to override chart values.
 global: