Skip to content

Commit 6fed5db

Browse files
committed
Fix comment replies action contrast
1 parent c4410fb commit 6fed5db

3 files changed

Lines changed: 13 additions & 0 deletions

File tree

app/src/main/res/layout/list_comment_item.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
android:ellipsize="end"
4242
android:lines="1"
4343
android:textAppearance="?android:attr/textAppearanceSmall"
44+
android:textColor="?attr/colorOnSurfaceVariant"
4445
android:textSize="@dimen/comment_item_title_text_size"
4546
tools:text="Author Name, Lorem ipsum • 5 months ago" />
4647

@@ -52,6 +53,7 @@
5253
android:layout_marginTop="6dp"
5354
android:layout_toEndOf="@+id/itemThumbnailView"
5455
android:textAppearance="?android:attr/textAppearanceLarge"
56+
android:textColor="?attr/colorOnSurface"
5557
android:textSize="@dimen/comment_item_content_text_size"
5658
tools:text="@tools:sample/lorem/random[1]" />
5759

@@ -99,6 +101,7 @@
99101
android:layout_alignParentEnd="true"
100102
android:layout_marginStart="@dimen/video_item_detail_heart_margin"
101103
android:minHeight="0dp"
104+
android:textColor="?attr/colorPrimary"
102105
tools:text="543 replies" />
103106

104107
</RelativeLayout>

doc/material3-fork-experiment.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,3 +1049,8 @@ Known risks / QA:
10491049
- The player seekbar active progress and visible thumb now resolve `colorPrimaryFixedDim`, replacing the old hard-coded red player tint path while leaving the inactive track and secondary progress behavior to the existing seekbar drawable/state handling.
10501050
- Playback, seeking, scrubbing gestures, player visibility/dismiss timing, fullscreen/embedded control behavior, thumbnail progress/duration spacing, downloads, and watch-progress calculation are unchanged by this color-only pass.
10511051
- Manual theme-color presets provide fixed-dim primary values for NewPipe Material, Neutral, Green, Blue, Purple, Orange, Pink, and Red. Follow system dynamic color can only feed this custom compatibility attr when the active theme/overlay supplies it; otherwise it falls back to the static NewPipe Material fixed-dim primary value.
1052+
1053+
### Comment replies contrast polish (latest)
1054+
1055+
- The comment-row replies action now uses the active theme `colorPrimary` role instead of inheriting a pale button text color, improving contrast for “N replies” on light surfaces while preserving dynamic/manual theme colors.
1056+
- Author/time metadata remains `colorOnSurfaceVariant`, comment body text remains `colorOnSurface`, and like/heart indicators plus reply loading behavior are unchanged.

doc/newpipe-material-roadmap.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -715,3 +715,8 @@ Before a public NewPipe Material release, manually verify:
715715
- Player seekbar color polish is complete as a focused color-only pass: an app-level `colorPrimaryFixedDim` compatibility attr is declared and mapped through base themes plus manual theme-color overlays.
716716
- The player seekbar active progress and visible thumb now use `colorPrimaryFixedDim` instead of the legacy hard-coded red tint path. Inactive track, secondary progress, playback, seeking, scrubbing gestures, fullscreen/embedded controls, player visibility timing, thumbnail progress/duration spacing, downloads, and watch-progress calculation remain unchanged.
717717
- Manual presets resolve to their fixed-dim primary colors, including Orange, Blue, Purple, and the default NewPipe Material green. Follow system dynamic color uses this custom attr only when supplied by the active theme/overlay; otherwise it uses the static NewPipe Material fixed-dim fallback.
718+
719+
### Comment replies contrast polish
720+
721+
- Comment row reply-count actions now use `colorPrimary` so “N replies” remains readable as an action/link across Light, Dark, Black, dynamic color, App default, and manual palettes. Comment author/time metadata stays on `colorOnSurfaceVariant`, and comment body text stays on `colorOnSurface`.
722+
- Scope is limited to comment-row XML color roles and this note; reply expansion/loading, like/heart indicators, comment parsing, player overlay, playback, and video-detail behavior are unchanged.

0 commit comments

Comments
 (0)