test(shape): cover move_vertex and translate mutation methods#2257
Merged
Conversation
The sibling mutation methods insert_point and remove_point are unit-tested, but move_vertex and translate (the drag-vertex and drag-shape primitives) had no direct coverage. Add tests pinning sub-pixel float precision, that move_vertex touches only the target vertex, and that translate shifts every point by the offset without changing the point count.
Owner
Author
Verdict: Test-only PR adding coverage for
CI is green across all 8 matrix jobs; branch is current with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shape.insert_pointandremove_pointare unit-tested, but their siblingmutation methods
move_vertex(drag a vertex) andtranslate(drag a wholeshape) had no direct coverage despite being core editing primitives. These tests
close that gap: they pin sub-pixel float precision, assert
move_vertexchangesonly the target vertex, and assert
translateshifts every point by the offsetwithout changing the point count.
Test plan
uv run pytest tests/unit/_shape_test.py -q(49 passed)uv run ruff check/uv run ty checkon the changed file