Missing space in the info screen

[gsieben]

What happened?

I am currently programming a usermod for the BMP680 sensor. I noticed that there is no space between the value and the unit on the info screen. In my opinion, this is a design bug. Because a unit must not contain a space. If you use the same units for HomeAssistant, you get an error message because of the space.

To Reproduce Bug

See the screen shot above

Expected Behavior

Spaces between value and unit

Install Method

Self-Compiled

What version of WLED?

WLED 0.14.1 build 2401141

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

I have already solved the problem for myself.

File: wled00/data/index.js
Line: 668

urows += inforow(k,val[0],val[1]);

changed to:

urows += inforow(k,val[0]," "+val[1]);

Code of Conduct

• I agree to follow this project's Code of Conduct

[softhack007]

I noticed that there is no space between the value and the unit on the info screen. In my opinion, this is a design bug

Hi,

I agree that's annoying, however we cannot change it now without breaking the look of most usermods that add to the info screen. Currently all usermods that want a space in column 3 add one explicitly.

Another usecase for "no space" is when a usermod wants to display values like "230ms" and a blank between 230 and "ms" is not desired. This would not be possible any more if we "force in" a blank.

So my preference is to keep as-is. The workaround is really simple, as you just add a space when doing infoArr.add(...) for building your additions to the info page.

[blazoncek]

I do not see this as a problem. Visual or otherwise.

[gsieben]

I see no reason to write 230ms without blank. That is not usual. Well, in the end it's a design question and the decision of the core team. Just my five cents.

[blazoncek]

FYI in Slovenia, it is considered normal to omit space between value and unit. In fact most technical documentation comes written such.
FYI2 this layout in info dialog has been since WLED 0.10. It is not something new.

And one more thing. If you want to interact with Home Assistant there is a sensor object specified in the API.
https://kno.wled.ge/interfaces/json-api/#sensors

[blazoncek]

Even though documentation says "DRAFT" it is actually implemented.

[Aircoookie]

Maybe we can consider adding narrow space by default as a compromise, see here, looks quite good.

We do use spaces between value and unit in the values included by default by WLED itself and it is the correct way according to the SI unit spec, so it should probably be preferred in 90% of cases.
Still the current behavior gives a lot of flexibility by allowing the usermod creator to choose whether to add a space or not when populating the infoArr.
Or do I misunderstand and doing that is exactly what causes HA to break?

@blazoncek oh, interesting! I didn't know Frenck implemented that API, nice. I will review and remove the draft label from the documentation.