tests: Remove usage of ReflectionMethod::setAccessible(), no-op

jdforrester · WMDE bot · commit 0bc09dde62d5 · 2025-10-09T08:00:18.000Z
Bug: T406744
Change-Id: I2ef7ddc1794bee0fef4d4d4a08210ca23a51a6fd
diff --git a/tests/unit/ByPropertyIdArrayTest.php b/tests/unit/ByPropertyIdArrayTest.php
@@ -71,7 +71,6 @@ public function testArrayObjectNotConstructedFromObject() {
 	protected static function getMethod( $methodName ) {
 		$class = new ReflectionClass( ByPropertyIdArray::class );
 		$method = $class->getMethod( $methodName );
-		$method->setAccessible( true );
 		return $method;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,6 @@ public function testArrayObjectNotConstructedFromObject() {`
`71`	`71`	`protected static function getMethod( $methodName ) {`
`72`	`72`	`$class = new ReflectionClass( ByPropertyIdArray::class );`
`73`	`73`	`$method = $class->getMethod( $methodName );`
`74`		`- $method->setAccessible( true );`
`75`	`74`	`return $method;`
`76`	`75`	`}`
`77`	`76`