Skip to content

Commit 54d0713

Browse files
matthiasmullieaddshore
authored andcommitted
Address review feedback
- renamed guid to guidPart - added version notes
1 parent e1c1d75 commit 54d0713

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

RELEASE-NOTES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Wikibase DataModel release notes
22

3+
## Version 9.4.0 (development)
4+
5+
* Added `getGuidPart` to `StatementGuid`
6+
37
## Version 9.3.0 (2020-03-10)
48

59
* Raised minimum PHP version to 7.1

src/Statement/StatementGuid.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class StatementGuid implements Comparable {
3131
/**
3232
* @var string
3333
*/
34-
private $guid;
34+
private $guidPart;
3535

3636
/**
3737
* @var string
@@ -51,7 +51,7 @@ public function __construct( EntityId $entityId, $guid ) {
5151

5252
$this->serialization = $entityId->getSerialization() . self::SEPARATOR . $guid;
5353
$this->entityId = $entityId;
54-
$this->guid = $guid;
54+
$this->guidPart = $guid;
5555
}
5656

5757
/**
@@ -62,10 +62,12 @@ public function getEntityId() {
6262
}
6363

6464
/**
65+
* @since 9.4
66+
*
6567
* @return string
6668
*/
67-
public function getGuid() {
68-
return $this->guid;
69+
public function getGuidPart() {
70+
return $this->guidPart;
6971
}
7072

7173
/**

tests/unit/Statement/StatementGuidTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function testConstructor( EntityId $entityId, $guid, $expected ) {
2626

2727
$this->assertSame( $expected, $statementGuid->getSerialization() );
2828
$this->assertEquals( $entityId, $statementGuid->getEntityId() );
29-
$this->assertEquals( $guid, $statementGuid->getGuid() );
29+
$this->assertEquals( $guid, $statementGuid->getGuidPart() );
3030
}
3131

3232
public function provideConstructionData() {

0 commit comments

Comments
 (0)