Use mediawiki-phan-config 0.16.0

jakobw · WMDE bot · commit a7bdb4e7a8de · 2025-07-14T16:23:35.000Z
The majority of issues were related to exception handling (unused exception variable, missing @throws annotation etc), and straightforward to fix. Bug: T398459 Change-Id: I5a459fd4c45eb73439ade6cca29109370468a495
diff --git a/src/Snak/SnakObject.php b/src/Snak/SnakObject.php
@@ -120,7 +120,7 @@ public function serialize() {
 	public function unserialize( $serialized ) {
 		try {
 			$this->propertyId = new NumericPropertyId( $serialized );
-		} catch ( InvalidArgumentException $ex ) {
+		} catch ( InvalidArgumentException ) {
 			// Backwards compatibility with the previous serialization format
 			$this->propertyId = NumericPropertyId::newFromNumber( unserialize( $serialized ) );
 		}

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ public function serialize() {`
`120`	`120`	`public function unserialize( $serialized ) {`
`121`	`121`	`try {`
`122`	`122`	`$this->propertyId = new NumericPropertyId( $serialized );`
`123`		`- } catch ( InvalidArgumentException $ex ) {`
	`123`	`+ } catch ( InvalidArgumentException ) {`
`124`	`124`	`// Backwards compatibility with the previous serialization format`
`125`	`125`	`$this->propertyId = NumericPropertyId::newFromNumber( unserialize( $serialized ) );`
`126`	`126`	`}`