Specify CEST Berlin timezone when parsing start and end dates of campaign

Author: moiikana

src/Utils/CampaignConfigurationLoader.php

@@ -95,8 +95,8 @@ private function buildCampaignFromData( string $campaignName, array $campaignDat
 
 		return new Campaign(
 			$campaignName,
-			new \DateTime( $start ),
-			new \DateTime( $end ),
+			new \DateTime( $start, new \DateTimeZone( 'Europe/Berlin' ) ),
+			new \DateTime( $end, new \DateTimeZone( 'Europe/Berlin' ) ),
 			$trafficLimit,
 			$category,
 			new SystemRandomIntegerGenerator(),

tests/Unit/Utils/CampaignConfigurationLoaderTest.php

@@ -47,6 +47,21 @@ public function test_given_campaigns_are_loaded_then_loaded_campaign_data_is_cor
 		$this->assertEquals( 'B18WPDE_02_180511_top_ctrl_last', $bucketA->getBanner( 10 ) );
 	}
 
+	public function test_loaded_campaign_start_end_dates_are_in_CET_Berlin_timezone(): void {
+		$loader = new CampaignConfigurationLoader( self::TEST_VALID_CAMPAIGN_CONFIGURATION_FILE );
+		$collection = $loader->getCampaignCollection();
+		$systemTimezone = date_default_timezone_get();
+		date_default_timezone_set( 'UTC' );
+
+		$campaign = $collection->getCampaign( new DateTime( "2018-11-31 01:23:45", new \DateTimeZone( 'Europe/Berlin' ) ) );
+
+		$this->assertNotNull( $campaign );
+		$this->assertSame( 'Europe/Berlin', $campaign->getEnd()->getTimezone()->getName() );
+
+		// restore system time zone
+		date_default_timezone_set( $systemTimezone );
+	}
+
 	public function test_given_broken_bucket_campaign_configuration_then_errors_are_caught(): void {
 		$loader = new CampaignConfigurationLoader(
 			self::TEST_BROKEN_BUCKET_CAMPAIGN_CONFIGURATION_FILE