Merge pull request #3116 from wmde/remove-sofort-config

Remove Sofort from config

Author: moiikana

.docker/app/config.dev.json

@@ -109,10 +109,6 @@
     "PPL": {
       "donation-enabled": true,
       "membership-enabled": false
-    },
-    "SUB": {
-      "donation-enabled": true,
-      "membership-enabled": false
     }
   },
   "cookie": {

app/config/config.dist.json

@@ -125,10 +125,6 @@
 		"PPL": {
 			"donation-enabled": true,
 			"membership-enabled": false
-		},
-		"SUB": {
-			"donation-enabled": true,
-			"membership-enabled": false
 		}
 	},
 	"preset-amounts": {

app/config/config.test.json

@@ -96,9 +96,6 @@
 		},
 		"PPL": {
 			"donation-enabled": true
-		},
-		"SUB": {
-			"donation-enabled": true
 		}
 	},
 	"user-data-key": "DiF8rUjXa2/pePFhQqB5ylDWfH/W5rlEXnrvf5/tNnk=",

tests/EdgeToEdge/Routes/AddDonationRouteTest.php

@@ -8,7 +8,6 @@
 use Monolog\Logger;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\MockObject\MockObject;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use WMDE\Fundraising\DonationContext\DataAccess\DoctrineEntities\Donation;
@@ -19,8 +18,6 @@
 use WMDE\Fundraising\Frontend\Tests\Fixtures\BucketLoggerSpy;
 use WMDE\Fundraising\Frontend\Tests\Fixtures\InMemoryTranslator;
 use WMDE\Fundraising\Frontend\Tests\Fixtures\PayPalAPISpy;
-use WMDE\Fundraising\PaymentContext\Services\PaymentUrlGenerator\Sofort\Response as SofortResponse;
-use WMDE\Fundraising\PaymentContext\Services\PaymentUrlGenerator\Sofort\SofortClient;
 
 #[CoversClass( AddDonationController::class )]
 class AddDonationRouteTest extends WebRouteTestCase {
@@ -445,35 +442,6 @@ public function testGivenValidCreditCardData_redirectsToPaymentProvider(): void
 		$this->assertStringContainsString( 'thatother.paymentprovider.com', $response->headers->get( 'Location' ) ?: '' );
 	}
 
-	public function testValidSofortInput_savesDonationAndRedirectsTo3rdPartyPage(): void {
-		$client = $this->createClient();
-		$response = new SofortResponse();
-		$response->setPaymentUrl( 'https://bankingpin.please' );
-
-		/** @var SofortClient&MockObject $sofortClient */
-		$sofortClient = $this->createMock( SofortClient::class );
-		$sofortClient
-			->method( 'get' )
-			->willReturn( $response );
-		$this->getFactory()->setSofortClient( $sofortClient );
-
-		$client->followRedirects( false );
-		$client->request(
-			'POST',
-			'/donation/add',
-			$this->newValidSofortInput()
-		);
-
-		$donation = $this->getDonationFromDatabase();
-
-		$this->assertSame( 'X', $donation->getStatus() );
-		$this->assertMatchesRegularExpression( '/^(XR)-[ACDEFKLMNPRTWXYZ349]{3}-[ACDEFKLMNPRTWXYZ349]{3}-[ACDEFKLMNPRTWXYZ349]/', $donation->getBankTransferCode() );
-
-		$response = $client->getResponse();
-		$this->assertTrue( $response->isRedirect() );
-		$this->assertSame( 'https://bankingpin.please', $response->headers->get( 'Location' ) );
-	}
-
 	/**
 	 * @return array<string, int|string>
 	 */
@@ -486,18 +454,6 @@ private function newValidCreditCardInput(): array {
 		];
 	}
 
-	/**
-	 * @return array<string, int|string>
-	 */
-	private function newValidSofortInput(): array {
-		return [
-			'amount' => '10000',
-			'paymentType' => 'SUB',
-			'interval' => 0,
-			'addressType' => 'anonym',
-		];
-	}
-
 	public function testGivenInvalidRequest_genericErrorMessageIsDisplayed(): void {
 		$client = $this->createClient();