Merge pull request #47 from wmde/vHtmlAndBind

Don’t clone node in `handleRawHtml()`

Author: codders

src/Component.php

@@ -319,11 +319,7 @@ private function handleRawHtml( DOMNode $node, array $data ) {
 			$variableName = $node->getAttribute( 'v-html' );
 			$node->removeAttribute( 'v-html' );
 
-			$newNode = $node->cloneNode( true );
-
-			$this->appendHTML( $newNode, $data[$variableName] );
-
-			$node->parentNode->replaceChild( $newNode, $node );
+			$this->appendHTML( $node, $data[$variableName] );
 		}
 	}
 

tests/php/TemplatingTest.php

@@ -102,6 +102,15 @@ public function testTemplateWithVhtmlVariable_ReplacesVariableWithGivenValue() {
 		$this->assertSame( '<div><div><p>some value</p></div></div>', $result );
 	}
 
+	public function testTemplateWithVhtmlVariableAndAttributeBinding_ReplacesBoth(): void {
+		$result = $this->createAndRender(
+			'<div><div :data-a="a" v-html="html"></div></div>',
+			[ 'a' => 'A', 'html' => '<p>HTML</p>' ]
+		);
+
+		$this->assertSame( '<div><div data-a="A"><p>HTML</p></div></div>', $result );
+	}
+
 	public function testTemplateWithVhtmlAndDiacritcsInValue_ReplacesVariableWithEncodedValue() {
 		$result = $this->createAndRender(
 			'<div><div v-html="value"></div></div>',