Use DOMNodeList with array syntax

lucaswerkmeister · lucaswerkmeister · commit 5bbd75bc7e7e · 2025-06-05T12:50:31.000+02:00
This is not only more readable, but also a bit faster [1] (though I doubt this code is a bottleneck anywhere either way). [1]: https://3v4l.org/NGEKe
diff --git a/src/HtmlParser.php b/src/HtmlParser.php
@@ -59,7 +59,7 @@ public function getRootNode( DOMDocument $document ): DOMElement {
 			throw new Exception( 'Template should have only one root node' );
 		}
 
-		return $rootNodes->item( 0 );
+		return $rootNodes[0];
 	}
 
 	/**
@@ -81,7 +81,7 @@ public function getHtmlElement( DOMDocument $document ): DOMElement {
 	 */
 	public function getBodyElement( DOMDocument $document ): DOMElement {
 		$htmlElement = $this->getHtmlElement( $document );
-		$bodyElement = $htmlElement->childNodes->item( 0 );
+		$bodyElement = $htmlElement->childNodes[0];
 		if ( $bodyElement->tagName !== 'body' ) {
 			throw new Exception( "Expected <body>, got <{$bodyElement->tagName}>" );
 		}

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public function getRootNode( DOMDocument $document ): DOMElement {`
`59`	`59`	`throw new Exception( 'Template should have only one root node' );`
`60`	`60`	`}`
`61`	`61`
`62`		`- return $rootNodes->item( 0 );`
	`62`	`+ return $rootNodes[0];`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`/**`
`@@ -81,7 +81,7 @@ public function getHtmlElement( DOMDocument $document ): DOMElement {`
`81`	`81`	`*/`
`82`	`82`	`public function getBodyElement( DOMDocument $document ): DOMElement {`
`83`	`83`	`$htmlElement = $this->getHtmlElement( $document );`
`84`		`- $bodyElement = $htmlElement->childNodes->item( 0 );`
	`84`	`+ $bodyElement = $htmlElement->childNodes[0];`
`85`	`85`	`if ( $bodyElement->tagName !== 'body' ) {`
`86`	`86`	`throw new Exception( "Expected <body>, got <{$bodyElement->tagName}>" );`
`87`	`87`	`}`