Fix removing multiple v-on event handlers

If we manipulate the DOM while iterating over it, the iteration may skip
elements. At the moment the library uses two different workarounds for
this: iterate over a shallow copy of the list using iterator_to_array()
(handleNode(), handleAttributeBinding()), or defer the manipulation
until after the loop (handleIf()). stripEventHandlers() did neither and
therefore failed to remove consecutive event handlers; fix that using
the defer approach, as I think that’s slightly more efficient in this
case. Also use removeAttributeNode() while we’re at it so that PHP
doesn’t have to look up the attribute by its name again.

Author: lucaswerkmeister

src/Component.php

@@ -74,12 +74,17 @@ private function stripEventHandlers( DOMNode $node ) {
 		if ( $this->isTextNode( $node ) ) {
 			return;
 		}
+		// Removing items while iterating breaks iteration, so defer attribute removal
+		$attributesToRemove = [];
 		/** @var DOMAttr $attribute */
 		foreach ( $node->attributes as $attribute ) {
 			if ( str_starts_with( $attribute->name, 'v-on:' ) ) {
-				$node->removeAttribute( $attribute->name );
+				$attributesToRemove[] = $attribute;
 			}
 		}
+		foreach ( $attributesToRemove as $attribute ) {
+			$node->removeAttributeNode( $attribute );
+		}
 	}
 
 	/**

tests/php/TemplatingTest.php

@@ -63,6 +63,12 @@ public function testTemplateHasOnClickHandlerInGrandChildNode_RemoveHandlerFormO
 		$this->assertSame( '<p><b><a></a></b></p>', $result );
 	}
 
+	public function testTemplateHasMultipleEventHandlers_RemoveAll(): void {
+		$result = $this->createAndRender( '<p v-on:click="x" v-on:keypress="y"></p>', [] );
+
+		$this->assertSame( '<p></p>', $result );
+	}
+
 	public function testTemplateWithSingleMustacheVariable_ReplacesVariableWithGivenValue() {
 		$result = $this->createAndRender( '<p>{{value}}</p>', [ 'value' => 'some value' ] );