Use textContent, not wholeText, to process text nodes #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wholeText property [1] [2] contains the text of the current text node together with any text nodes adjacent to it. Given that we’re processing each text node separately, this doesn’t make sense and means we’re potentially processing the same text multiple times – we should just process textContent instead, which is the node’s own text. I initially thought this bug wouldn’t be reproducible in practice without manually constructing a DOM with two adjacent text nodes, but then I realized a v-if with a false condition can easily produce such a DOM naturally, hence the test case. [1]: https://www.php.net/manual/en/class.domtext.php#domtext.props.wholetext [2]: https://developer.mozilla.org/en-US/docs/Web/API/Text/wholeText
Member
Author
|
Output of the test without the fix: 1) WMDE\VueJsTemplating\Test\TemplatingTest::testMustacheAfterVIf
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'<p>a: A c: C</p>'
+'<p>a: A c: Ca: A c: Cc: C</p>' |
yerdua
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wholeText property 1 2 contains the text of the current text node together with any text nodes adjacent to it. Given that we’re processing each text node separately, this doesn’t make sense and means we’re potentially processing the same text multiple times – we should just process textContent instead, which is the node’s own text.
I initially thought this bug wouldn’t be reproducible in practice without manually constructing a DOM with two adjacent text nodes, but then I realized a v-if with a false condition can easily produce such a DOM naturally, hence the test case.
Just a random bug I noticed while staring at the code ^^