Skip to content

Throw errors from HTML parsing #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Throw errors from HTML parsing #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/HtmlParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function parseHtml( string $html ): DOMDocument {
// LIBXML_NOBLANKS Constant excludes "ghost nodes" to avoid violating
// vue's single root node constraint
if ( !$document->loadHTML( '<?xml encoding="utf-8" ?>' . $html, LIBXML_NOBLANKS ) ) {
//TODO Test failure
throw new Exception( 'Failed to parse HTML' );
}

/** @var LibXMLError[] $errors */
Expand All @@ -41,9 +41,15 @@ public function parseHtml( string $html ): DOMDocument {
libxml_disable_entity_loader( $entityLoaderDisabled );
}

$exception = null;
foreach ( $errors as $error ) {
//TODO html5 tags can fail parsing
//TODO Throw an exception
if ( strpos( $error->message, 'Tag template invalid' ) === 0 ) {
continue;
}
$exception = new Exception( $error->message, $error->code, $exception );
}
if ( $exception !== null ) {
throw $exception;
}

return $document;
Expand Down
7 changes: 7 additions & 0 deletions tests/php/HtmlParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,11 @@ public function testTwoRootNodes() {
$this->parseAndGetRootNode( '<p></p><p></p>' );
}

public function testMalformedHtml(): void {
$htmlParser = new HtmlParser();
$this->expectException( Exception::class );
$this->expectExceptionMessage( 'Unexpected end tag' );
$htmlParser->parseHtml( '</p>' );
}

}