Skip to content

Conversation

@lucaswerkmeister
Copy link
Member

@lucaswerkmeister lucaswerkmeister commented Jun 10, 2025


While this has been contentious in other libraries in the past, my position is that this should not be considered a semver breaking change, because:

  • PHP < 8.1 is no longer supported by PHP.
  • Composer takes the PHP requirements into account when selecting a library version. If someone is still on PHP 7.4, Composer won’t install a newer version of this library, so nothing will break for them.
  • The last bump (ef70bb5) was also in a patch release.

@lucaswerkmeister lucaswerkmeister requested a review from codders June 10, 2025 15:52
@lucaswerkmeister lucaswerkmeister changed the title Bump PHP requirement to 8.0 Bump PHP requirement to 8.1 Jun 11, 2025
@lucaswerkmeister
Copy link
Member Author

Bumped the target version from 8.0 to 8.1 following @manicki’s suggestion.

@mariushoch mariushoch merged commit 8847d9b into master Jun 11, 2025
8 checks passed
@mariushoch mariushoch deleted the php8 branch June 11, 2025 09:34
@lucaswerkmeister
Copy link
Member Author

While this has been contentious in other libraries in the past, my position is that this should not be considered a semver breaking change…

See also T396824.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants