Two minor cleanups #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these are technically slight behavior changes, but not significant ones IMHO.
If we manipulate the DOM while iterating over it, the iteration may skip elements. At the moment the library uses two different workarounds for this: iterate over a shallow copy of the list using iterator_to_array() (handleNode(), handleAttributeBinding()), or defer the manipulation until after the loop (handleIf()). stripEventHandlers() did neither and therefore failed to remove consecutive event handlers; fix that using the defer approach, as I think that’s slightly more efficient in this case. Also use removeAttributeNode() while we’re at it so that PHP doesn’t have to look up the attribute by its name again.
Merged
codders
approved these changes
Jun 12, 2025
Contributor
codders
left a comment
codders
left a comment
There was a problem hiding this comment.
Looks good - let's do it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.