Skip to content

Support @ shorthand for v-on: directive #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

Support @ shorthand for v-on: directive #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ab28dc
Fix typo in test names
lucaswerkmeister Jun 13, 2025
e025c92
Support @ shorthand for v-on: directive
lucaswerkmeister Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Component.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ private function stripEventHandlers( DOMNode $node ) {
$attributesToRemove = [];
/** @var DOMAttr $attribute */
foreach ( $node->attributes as $attribute ) {
if ( str_starts_with( $attribute->name, 'v-on:' ) ) {
if (
str_starts_with( $attribute->name, 'v-on:' ) ||
str_starts_with( $attribute->name, '@' )
) {
$attributesToRemove[] = $attribute;
}
}
Expand Down
4 changes: 4 additions & 0 deletions src/HtmlParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ public function parseHtml( string $html ): DOMDocument {
// discard "Tag xyz invalid" messages from libxml2 < 2.14.0(?)
continue;
}
if ( $msg === "error parsing attribute name\n" ) {
// discard these messages (e.g. @event="") from libxml < 2.14.0(?)
continue;
}
$exception = new Exception( $msg, $error->code, $exception );
}
if ( $exception !== null ) {
Expand Down
14 changes: 10 additions & 4 deletions tests/php/TemplatingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,30 +39,36 @@ public function testSingleFileComponent(): void {
$this->assertSame( '<div></div>', $result );
}

public function testTemplateHasOnClickHandler_RemoveHandlerFormOutput() {
public function testTemplateHasOnClickHandler_RemoveHandlerFromOutput() {
$result = $this->createAndRender( '<div v-on:click="doStuff"></div>', [] );

$this->assertSame( '<div></div>', $result );
}

public function testTemplateHasOnClickHandlerAndPreventDefault_RemoveHandlerFormOutput() {
public function testTemplateHasOnClickHandlerAndPreventDefault_RemoveHandlerFromOutput() {
$result = $this->createAndRender( '<div v-on:click.prevent="doStuff"></div>', [] );

$this->assertSame( '<div></div>', $result );
}

public function testTemplateHasOnClickHandlerInSomeChildNode_RemoveHandlerFormOutput() {
public function testTemplateHasOnClickHandlerInSomeChildNode_RemoveHandlerFromOutput() {
$result = $this->createAndRender( '<p><a v-on:click="doStuff"></a></p>', [] );

$this->assertSame( '<p><a></a></p>', $result );
}

public function testTemplateHasOnClickHandlerInGrandChildNode_RemoveHandlerFormOutput() {
public function testTemplateHasOnClickHandlerInGrandChildNode_RemoveHandlerFromOutput() {
$result = $this->createAndRender( '<p><b><a v-on:click="doStuff"></a></b></p>', [] );

$this->assertSame( '<p><b><a></a></b></p>', $result );
}

public function testTemplateHasOnClickHandlerWithShorthand_RemoveHandlerFromOutput(): void {
$result = $this->createAndRender( '<p @click="x"></p>', [] );

$this->assertSame( '<p></p>', $result );
}

public function testTemplateHasMultipleEventHandlers_RemoveAll(): void {
$result = $this->createAndRender( '<p v-on:click="x" v-on:keypress="y"></p>', [] );

Expand Down