Add complex expression handling with Peast #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codders
force-pushed
the
feat/peast-complex-expression-support-20250625
branch
from
a51db66 to
9fb9cb6
Compare
Until now the Javascript expression handling has been limited to
simple expressions and has used regexps to process the strings of
Javascript code. As we move to support more advanced Vue features,
we need to be able to process more complex Javascript expressions
and need to move away from regexps.
Peast is a library that is already used in Mediawiki that converts
Javascript expressions into an abstract syntax tree representation.
Using Peast we can more reliably parse Javascript and implement
more complex expression handling.
Refactor the existing BasicJsExpressionParser to use Peast, and
add handling of Object expressions (`{ test: 'value' }`).
Bug: T396855
codders
force-pushed
the
feat/peast-complex-expression-support-20250625
branch
from
9fb9cb6 to
2ed9ddd
Compare
lucaswerkmeister
approved these changes
Jun 27, 2025
lucaswerkmeister
deleted the
feat/peast-complex-expression-support-20250625
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the Javascript expression handling has been limited to simple expressions and has used regexps to process the strings of Javascript code. As we move to support more advanced Vue features, we need to be able to process more complex Javascript expressions and need to move away from regexps.
Peast is a library that is already used in Mediawiki that converts Javascript expressions into an abstract syntax tree representation. Using Peast we can more reliably parse Javascript and implement more complex expression handling.
Refactor the existing BasicJsExpressionParser to use Peast, and add handling of Object expressions (
{ test: 'value' }).Bug: T396855