Add support for more literals, and binary expressions #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yerdua
reviewed
Jul 2, 2025
Contributor
yerdua
left a comment
yerdua
left a comment
There was a problem hiding this comment.
looks good to me! there's some conflicts though that prevent merging.
Add limited support for binary expression ( `a != 3` ). The support is limited to comparing numbers, strings and bools with one another, and restricted to comparison operators common between Javascript and PHP. Bug: T398308
codders
force-pushed
the
feat/add-literals-and-binary-expressions-20250702
branch
from
26fc700 to
50d3771
Compare
Contributor
Author
|
rebased now. |
yerdua
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add limited support for binary expression (
a != 3). The support is limited to comparing numbers, strings and bools with one another, and restricted to comparison operators common between Javascript and PHP.Bug: T398308