docs: fix update instructions

[rti]

This ensures that docker compose always checks for new images when starting the WBS Deploy stack. Actually, we expected this behavior being present already. It is also already documented like that. That's why I consider this a fix and not a feat.

[lorenjohnson]

Hey @rti, I have a thought on this. With pull_policy: always new images will be pulled even after just doing a docker compose stop and docker compose up, so on every ordinary reboot. So I think this pull_policy solution actually changes the behaviour we stated and makes patch and minor updates automatic, and no longer optional.

docker compose pull is another way to achieve this, such that the user determines explicitly when they want to receive updates and the images don't re-pull every time. I think this aligns with our current explanations in the README and I'd prefer adding it to the instructions at https://github.com/wmde/wikibase-release-pipeline/tree/main/deploy#minor-and-patch-updates-for-wbs-images, such that instead of:

docker compose down
docker compose up

We make the instructions there:

docker compose down
docker compose pull
docker compose up

And leave the service configuration as they are. If we want to expand there README you could document this option to always pull and/or make it an env var, i.e. pull_policy: ${PULL_POLICY}, with a default of missing and a note about the option for fully automatic updates (on restart) by setting it it always (https://docs.docker.com/reference/compose-file/services/#pull_policy.

Hope that makes sense.

[rti]

Thanks. Good catch. That does indeed make sense. Will update the PR accordingly.

[lorenjohnson]

Please see final discussion really, and amend or merge as you see fit

[rti]

Thanks lot for your thoughts and the review.