Skip to content

Commit b587c18

Browse files
committed
doc: final javadoc cleanup
Signed-off-by: Dasun Abeykoon <[email protected]>
1 parent bc2cc86 commit b587c18

File tree

1 file changed

+12
-1
lines changed
  • src/main/java/org/frc6423/robot/subsystems/superstructure/elevator

1 file changed

+12
-1
lines changed

src/main/java/org/frc6423/robot/subsystems/superstructure/elevator/Elevator.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,28 @@
3535
/** Elevator Subsystem */
3636
public class Elevator extends SubsystemBase implements AutoCloseable {
3737
// * CONSTANTS
38+
/** Gear ratio of the elevator gearbox */
3839
public static final double GEAR_REDUCTION = 3 / 1;
3940

4041
/** The radius of the sproket on the elevator's driven shaft */
4142
public static final Distance DRUM_RADIUS = Inches.of(1.757 / 2);
4243

44+
/** The ratio of motor revs over output extension in meters */
4345
public static final double SENSOR_TO_MECH_RATIO = 3 / (2 * Math.PI * DRUM_RADIUS.in(Meters));
46+
47+
/** Combined mass lifted by elevator gearbox */
4448
public static final Mass LIFT_MASS = Pounds.of(6.0); // TODO calculate actual value
4549

50+
/** The highest feasible extension height */
4651
public static final Distance MAX_EXTENSION_HEIGHT = Inches.of(24);
52+
53+
/** The max allowable height extension error */
4754
public static final Distance TOLERANCE = Inches.of(1.5);
4855

56+
/** The velocity limit of the elevator's trapezoid profile */
4957
public static final LinearVelocity MAX_VELOCITY = MetersPerSecond.of(4.5);
58+
59+
/** The acceleration of the elevator's trapezoid profile */
5060
public static final LinearAcceleration MAX_ACCELERATION = MetersPerSecondPerSecond.of(10.0);
5161

5262
@Logged(name = "Elevator Hardware Loggables")
@@ -89,6 +99,7 @@ public void periodic() {
8999

90100
filteredCurrent = currentFilter.calculate(hardware.getParentStatorCurrentAmps());
91101

102+
/** Set visualizer poses */
92103
stageRoot.setPosition(
93104
(MAX_EXTENSION_HEIGHT.in(Centimeters) / 2) - 2, getStageHeight().in(Centimeters));
94105
carriageRoot.setPosition(
@@ -173,7 +184,7 @@ public Command runExtension(ElevatorExtension extension) {
173184
* Run elevator to specified extension height
174185
*
175186
* @param extension {@link Distance} representing desired extension height
176-
* @return
187+
* @return {@link Command}
177188
*/
178189
public Command runExtension(Distance extension) {
179190
return this.run(() -> hardware.setPose(extension.in(Meters)));

0 commit comments

Comments
 (0)