Skip to content

Commit 033a85e

Browse files
authored
Merge pull request #447 from wneessen/bug/446_emltomsgfromstring-failed-with-attachments
Fix assignment to nil map in EML parser
2 parents 3978049 + baf5162 commit 033a85e

File tree

4 files changed

+355
-394
lines changed

4 files changed

+355
-394
lines changed

REUSE.toml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@
44

55
version = 1
66
SPDX-PackageName = "go-mail"
7-
SPDX-PackageSupplier = "Winni Neessen <winni@neessen.dev>"
7+
SPDX-PackageSupplier = "The go-mail Authors"
88
SPDX-PackageDownloadLocation = "https://github.com/wneessen/go-mail"
9-
annotations = []
9+
10+
[[annotations]]
11+
path = ["testdata/**"]
12+
precedence = "aggregate"
13+
SPDX-FileCopyrightText = "The go-mail Authors"
14+
SPDX-License-Identifier = "MIT"

eml.go

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,7 @@ func EMLToMsgFromString(emlString string) (*Msg, error) {
4848
// - A pointer to the Msg object populated with the parsed data, and an error if parsing
4949
// fails.
5050
func EMLToMsgFromReader(reader io.Reader) (*Msg, error) {
51-
msg := &Msg{
52-
addrHeader: make(map[AddrHeader][]*netmail.Address),
53-
genHeader: make(map[Header][]string),
54-
preformHeader: make(map[Header]string),
55-
mimever: MIME10,
56-
}
57-
51+
msg := NewMsg()
5852
parsedMsg, bodybuf, err := readEMLFromReader(reader)
5953
if err != nil || parsedMsg == nil {
6054
return msg, fmt.Errorf("failed to parse EML from reader: %w", err)
@@ -81,13 +75,7 @@ func EMLToMsgFromReader(reader io.Reader) (*Msg, error) {
8175
// - A pointer to the Msg object populated with the parsed data, and an error if parsing
8276
// fails.
8377
func EMLToMsgFromFile(filePath string) (*Msg, error) {
84-
msg := &Msg{
85-
addrHeader: make(map[AddrHeader][]*netmail.Address),
86-
genHeader: make(map[Header][]string),
87-
preformHeader: make(map[Header]string),
88-
mimever: MIME10,
89-
}
90-
78+
msg := NewMsg()
9179
parsedMsg, bodybuf, err := readEML(filePath)
9280
if err != nil || parsedMsg == nil {
9381
return msg, fmt.Errorf("failed to parse EML file: %w", err)

0 commit comments

Comments
 (0)