-
-
Notifications
You must be signed in to change notification settings - Fork 86
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Description
In smtp.smtp.go:87 the EHLO error is ignored and the library returns a generic EOF which is out of context. It should instead return the error given to EHLO, which can help figuring out configuration issues since it's the server response.
// hello runs a hello exchange if needed.
func (c *Client) hello() error {
if !c.didHello {
c.didHello = true
err := c.ehlo()
if err != nil {
c.helloError = c.helo()
}
}
return c.helloError
}To Reproduce
Misconfigure LocalName for example with one that has spaces, gmail responds with an error
Expected behaviour
A clear error is shown the moment it happens
Screenshots
No response
Attempted Fixes
No response
Additional context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working