Improve code quality: move yaml import to module level#125
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
…ng whitespace - Move 'import yaml' from inside try block to module-level imports in linkedin.py for better PEP 8 compliance - Remove trailing whitespace from constants.py (line 12) - These changes improve code quality and prevent inline imports which are considered anti-patterns Co-authored-by: Ongun Demirag <ongun@ongundemirag.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
yamlimport to module-level: Movedimport yamlfrom inside a try block in thefillPhoneNumber()method to the module-level imports inlinkedin.py. Inline imports within exception handlers are considered anti-patterns and reduce code clarity.constants.pyline 12.Quality Improvements
These changes improve code quality by:
Testing
py_compile