Improve code quality in utils.py#127
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
- Add return type hint to chromeBrowserOptions() function - Fix inconsistent indentation in jobsToPages() (2-space to 4-space) - Add docstrings to color print functions (prRed, prGreen, prYellow) - Clean up whitespace and formatting in writeResults() function - Remove unnecessary parentheses and improve code readability Co-authored-by: Ongun Demirag <ongun@ongundemirag.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Quality Improvements
This PR makes small, focused improvements to enhance code quality and consistency:
Changes:
chromeBrowserOptions()function - now properly typed aswebdriver.ChromeOptionsjobsToPages()function - converted from 2-space to 4-space indentation for consistency with the rest of the codebaseprRed,prGreen,prYellow) to improve code documentationwriteResults()function - removed inconsistent spacing around operators and function callsBenefits: