fix: Use platform-aware chromedriver path for cross-OS compatibility#130
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix: Use platform-aware chromedriver path for cross-OS compatibility#130cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
- Detect OS using platform.system() to determine correct chromedriver binary name - Use 'chromedriver.exe' on Windows and 'chromedriver' on Unix-like systems - Fixes issues with Linux/Docker environments where .exe extension causes failure - Maintains existing fallback mechanism for robustness Co-authored-by: Ongun Demirag <ongun@ongundemirag.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bot hardcoded
chromedriver.exeas the chromedriver binary name, which fails on Linux systems (including the Docker container) where the binary is namedchromedriverwithout the.exeextension.Solution
platform.system()chromedriver.exeon Windows,chromedriveron Unix-like systems (Linux, macOS)Impact