Fix set but not used

Author: dgarske

Makefile

@@ -104,8 +104,12 @@ CFLAGS+= \
 
 # Setup default optimizations (for GCC)
 ifeq ($(USE_GCC_HEADLESS),1)
-  CFLAGS+=-Wall -Wextra -Wno-main -ffreestanding -Wno-unused -nostartfiles
-  CFLAGS+=-ffunction-sections -fdata-sections -fomit-frame-pointer -Wunused-variable
+  CFLAGS+=-Wall -Wextra -Wno-main -ffreestanding -nostartfiles
+  CFLAGS+=-ffunction-sections -fdata-sections -fomit-frame-pointer
+  # Allow unused parameters and functions
+  CFLAGS+=-Wno-unused-parameter -Wno-unused-function
+  # Error on unused variables
+  CFLAGS+=-Wunused-variable
   LDFLAGS+=-Wl,-gc-sections -Wl,-Map=wolfboot.map -ffreestanding -nostartfiles
   # Not setting LDFLAGS directly since it is passed to the test-app
   LSCRIPT_FLAGS+=-T $(LSCRIPT)

arch.mk

@@ -106,7 +106,9 @@ ifeq ($(ARCH),AARCH64)
     CFLAGS+=$(ARCH_FLAGS) -DWOLFSSL_ARMASM -DWOLFSSL_ARMASM_INLINE -DWC_HASH_DATA_ALIGNMENT=8 -DWOLFSSL_AARCH64_PRIVILEGE_MODE
     WOLFCRYPT_OBJS += $(WOLFBOOT_LIB_WOLFSSL)/wolfcrypt/src/cpuid.o \
                       $(WOLFBOOT_LIB_WOLFSSL)/wolfcrypt/src/port/arm/armv8-sha512-asm_c.o \
-                      $(WOLFBOOT_LIB_WOLFSSL)/wolfcrypt/src/port/arm/armv8-sha3-asm_c.o
+                      $(WOLFBOOT_LIB_WOLFSSL)/wolfcrypt/src/port/arm/armv8-sha3-asm_c.o \
+                      $(WOLFBOOT_LIB_WOLFSSL)/wolfcrypt/src/port/arm/armv8-aes-asm_c.o \
+                      $(WOLFBOOT_LIB_WOLFSSL)/wolfcrypt/src/port/arm/armv8-sha256-asm_c.o
   endif
 endif
 

hal/nrf5340.c

@@ -673,7 +673,7 @@ static void hal_net_check_version(void)
     }
     /* proceed to update_flash routines */
 #endif /* TARGET_nrf5340_* */
-exit:
+    (void)status;
     wolfBoot_printf("Status: App %s (ver %d), Net %s (ver %d)\n",
         hal_shm_status_string(shm->core.app.status), shm->core.app.version,
         hal_shm_status_string(shm->core.net.status), shm->core.net.version);

hal/nxp_p1021.c

@@ -1164,10 +1164,7 @@ static void config_io_pin(uint8_t port, uint8_t pin, int dir, int open_drain,
 
 static void read_io_pin(uint8_t port, uint8_t pin, int *data)
 {
-    uint32_t pin_1bit_mask, tmp_val;
-
-    /* Calculate pin location for 1bit mask */
-    pin_1bit_mask = (uint32_t)(1 << (NUM_OF_PINS - (pin + 1)));
+    uint32_t tmp_val;
 
     /* Read the data */
     tmp_val = get32(GUTS_CPDAT(port));
@@ -1569,6 +1566,7 @@ static void hal_irq_init(void)
 
     set32(PIC_GCR, PIC_GCR_M); /* eanble mixed-mode */
     reg = get32(PIC_GCR); /* read back */
+    (void)reg;
 }
 #endif
 
@@ -1687,6 +1685,7 @@ int ext_flash_write(uintptr_t address, const uint8_t *data, int len)
                     ELBC_FIR_OP(4, ELBC_FIR_OP_WB) |
                     ELBC_FIR_OP(5, ELBC_FIR_OP_CW1));
 #endif
+    (void)block_size; /* not used - shown for reference */
 
     /* page write loop */
     while (pos < len) {
@@ -1719,6 +1718,7 @@ int ext_flash_write(uintptr_t address, const uint8_t *data, int len)
         wolfBoot_printf("write page %d, col %d, status %x\n",
             page, col, status);
 #endif
+        (void)status;
         address += page_size - col;
         pos += page_size - col;
         data += page_size - col;
@@ -1859,6 +1859,7 @@ int ext_flash_erase(uintptr_t address, int len)
 #ifdef DEBUG_EXT_FLASH
         wolfBoot_printf("erase page %d, status %x\n", page, status);
 #endif
+        (void)status;
         len -= block_size;
     }
 

hal/stm32c0.c

@@ -234,6 +234,7 @@ static void clock_pll_on(int powersave)
 
     /* Select clock parameters (CPU Speed = 48MHz) */
     cpu_freq = 48000000;
+    (void)cpu_freq; /* not used */
     flash_waitstates = 1;
 
     flash_set_waitstates(flash_waitstates);

hal/stm32f7.c

@@ -347,6 +347,7 @@ static void clock_pll_on(int powersave)
     ppre2 = RCC_PRESCALER_DIV_2;
     flash_waitstates = 7;
     cpu_freq = 216000000;
+    (void)cpu_freq; /* not used */
 
     flash_set_waitstates(flash_waitstates);
 

hal/stm32g0.c

@@ -229,6 +229,8 @@ static void clock_pll_on(int powersave)
     hpre  = RCC_PRESCALER_DIV_NONE;
     ppre = RCC_PRESCALER_DIV_NONE;
     flash_waitstates = 2;
+    (void)cpu_freq; /* not used */
+    (void)pllq; /* not used */
 
     flash_set_waitstates(flash_waitstates);
 

hal/stm32l0.c

@@ -248,6 +248,9 @@ static void clock_pll_on(int powersave)
     /* Wait for PLL clock to be selected. */
     while (((RCC_CFGR >> 2) & 0x03) != RCC_CFGR_SW_PLL)
         ;
+
+    (void)hsi_freq; /* not used */
+    (void)cpu_freq; /* not used */
 }
 
 void hal_init(void)

hal/stm32l4.c

@@ -286,9 +286,7 @@ void hal_prepare_boot(void)
  * It is defined here only to avoid a compiler error
  * for a missing symbol in hal_flash_driver.
  */
-#ifdef __WOLFBOOT
 uint32_t HAL_GetTick(void)
 {
     return 0;
 }
-#endif

hal/stm32wb.c

@@ -263,6 +263,7 @@ static void clock_pll_on(void)
     cpu_freq = 64000000;
     flash_waitstates = 4;
     flash_set_waitstates(flash_waitstates);
+    (void)cpu_freq; /* not used */
 
     /* Configure + enable internal high-speed oscillator. */
     RCC_CR = (RCC_CR & (~RCC_CR_MSIRANGE_Msk)) | RCC_CR_MSIRANGE_6;