new test cases to check overlong curve name and keytype argument

Author: JacobBarthelmeh

tests/genkey_sign_ver/genkey-sign-ver-test.py

@@ -392,5 +392,18 @@ def test_xmss_missing_height_value(self):
                                 "{}".format(r.returncode))
 
 
+class GenkeyArgvTest(unittest.TestCase):
+    """Argument-bounds checks for the genkey subcommand entry point."""
+
+    def test_genkey_no_keytype(self):
+        """`wolfssl genkey` with no key-type argument must not deref argv[2]."""
+        r = run_wolfssl("genkey")
+        self.assertNotEqual(r.returncode, 0,
+                            "expected failure with no key type")
+        self.assertGreaterEqual(r.returncode, 0,
+                                "genkey with no key type crashed with signal "
+                                "{}".format(r.returncode))
+
+
 if __name__ == "__main__":
     test_main()

tests/pkey/ecparam-test.py

@@ -135,6 +135,19 @@ def test_fail_bad_curve_name(self):
         self.assertFalse(os.path.exists("tmp_ecparam.key"),
                          "key file should not be created for bad curve")
 
+    def test_fail_overlong_curve_name(self):
+        """Curve name >= ECC_MAXNAME bytes must not crash (no over-read)."""
+        self._cleanup("tmp_ecparam.key")
+
+        long_name = "A" * 256
+        r = run_wolfssl("ecparam", "-genkey", "-name", long_name,
+                        "-out", "tmp_ecparam.key")
+        self.assertNotEqual(r.returncode, 0,
+                            "expected failure for overlong curve name")
+        self.assertGreaterEqual(r.returncode, 0,
+                                "overlong curve name crashed with signal "
+                                "{}".format(r.returncode))
+
     def test_all_curves_genkey(self):
         """Re-run curve test using the genkey command."""
         names = _get_curve_names()