Keeping track of items that still need addressed

[JacobBarthelmeh]

Trying to capture all items from review so far to make sure they are addressed.

• Remove all fopen/fclose in preference of either WOLFSSL_BIO's or XFOPEN/XFCLOSE
• Portability with dynamic buffer declarations (change to dynamic heap allocations instead of on stack)
• Optimization of writing out to files (make sure is not written in DER then re written in PEM)
• Optimization of reduction in XMEMSET's used on buffers
• Fix for use of scanf and sanity checks around it's inputs
• Refactor of wolfCLU_hexToBin to reduce it's complexity and number of arguments
• Use ret checks and fall threw in function rather than wolfCLU_freeBins
• Pass through the code to remove magic numbers i.e case 0 in clu_main.c and existing set of keyType value
• add debug mode (adds enable-debug (-g -O0) and defaults to -O2 without debug #4)
• add Wall flag (adds Wall to CFLAG, remove stomping on CFLAG, update automake version, and fix for warning #3)
• refactor of free_things* functions such as the one in clu_certgen_rsa.c
• update all file license headers

[lantis1008]

Hi Jacob, any progress towards a gencrl type command? I was going to have a go at implementing myself, but don't want to waste time if you've already got it staged elsewhere.
Thanks for your efforts on this.

Edit: That being said after looking at it for most of the weekend i'm not much closer

[lealem47]

Hi Jacob, any progress towards a gencrl type command? I was going to have a go at implementing myself, but don't want to waste time if you've already got it staged elsewhere. Thanks for your efforts on this.

Edit: That being said after looking at it for most of the weekend i'm not much closer

@lantis1008 Have you looked into using the crl command?

[lantis1008]

@lealem47 correct me if I'm mistaken, but the CRL command appears to only be for parsing/verifying a CRL?
I'm looking for the ability to write out a CRL.
I think there was no function to write out a BIO in that format when I was looking?

See this in OpenSSL for example

https://github.com/openssl/openssl/blob/master/apps/ca.c#L1145