Code review feedback

kareem-wolfssl · kareem-wolfssl · commit b592aeccb42a · 2026-07-22T10:30:41.000-07:00
diff --git a/src/ssl.c b/src/ssl.c
@@ -8303,7 +8303,7 @@ size_t wolfSSL_get_client_random(const WOLFSSL* ssl, unsigned char* out,
                  * decoded contents. InitX509 only zeroes the pointers, so free
                  * the existing allocations first to avoid orphaning them. */
                 FreeX509(x509);
-                InitX509(x509, 0, NULL);
+                InitX509(x509, 0, x509->heap);
             }
             ret = CopyDecodedToX509(x509, cert);
         }

Original file line number	Diff line number	Diff line change
`@@ -8303,7 +8303,7 @@ size_t wolfSSL_get_client_random(const WOLFSSL* ssl, unsigned char* out,`
`8303`	`8303`	`* decoded contents. InitX509 only zeroes the pointers, so free`
`8304`	`8304`	`* the existing allocations first to avoid orphaning them. */`
`8305`	`8305`	`FreeX509(x509);`
`8306`		`- InitX509(x509, 0, NULL);`
	`8306`	`+ InitX509(x509, 0, x509->heap);`
`8307`	`8307`	`}`
`8308`	`8308`	`ret = CopyDecodedToX509(x509, cert);`
`8309`	`8309`	`}`