Code review feedback

kareem-wolfssl · kareem-wolfssl · commit d15a66e96c21 · 2026-07-22T10:39:01.000-07:00
diff --git a/src/ssl_api_cert.c b/src/ssl_api_cert.c
@@ -2726,7 +2726,7 @@ int wolfSSL_get0_chain_certs(WOLFSSL *ssl, WOLF_STACK_OF(WOLFSSL_X509) **sk)
                  * decoded contents. InitX509 only zeroes the pointers, so free
                  * the existing allocations first to avoid orphaning them. */
                 FreeX509(x509);
-                InitX509(x509, 0, NULL);
+                InitX509(x509, 0, x509->heap);
             }
             ret = CopyDecodedToX509(x509, cert);
         }

Original file line number	Diff line number	Diff line change
`@@ -2726,7 +2726,7 @@ int wolfSSL_get0_chain_certs(WOLFSSL ssl, WOLF_STACK_OF(WOLFSSL_X509) *sk)`
`2726`	`2726`	`* decoded contents. InitX509 only zeroes the pointers, so free`
`2727`	`2727`	`* the existing allocations first to avoid orphaning them. */`
`2728`	`2728`	`FreeX509(x509);`
`2729`		`- InitX509(x509, 0, NULL);`
	`2729`	`+ InitX509(x509, 0, x509->heap);`
`2730`	`2730`	`}`
`2731`	`2731`	`ret = CopyDecodedToX509(x509, cert);`
`2732`	`2732`	`}`