Merge pull request #53364 from AmberArcadia/amber-claude-fixes

Added extra info to CLAUDE.md, which was used to create a test for amazon-corretto-crypto-provider

Author: dnegreira

.gitignore

@@ -27,6 +27,7 @@ tramp
 .\#*
 
 **/.github-token
+**/.claude/settings.local.json
 
 # QEMU images
 *.img

CLAUDE.md

@@ -59,6 +59,14 @@ Try to reuse existing melange pipelines where possible.
 
 When debugging failed builds, try cloning the source code from the melange file locally to a directory here to study the build system.
 
+## Other General notes
+Follow the previously mentioned notes as a baseline, and then also consider these additional notes:
+- Certain packages are a bit weird, like Java and Python. Make sure to check existing examples, but especially note the following:
+  - Use py3.x-supported-y packages whenever possible
+  - Use a modern and supported JVM/JDK version (making sure to pick the right packages as well) and loading the environment variables properly
+  - Avoid using obsolete package versions
+- It is worthwhile to search for similar packages to use as working examples over generating something entirely new.
+
 ## Ruby Package Guidelines
 
 When working with Ruby packages:

amazon-corretto-crypto-provider.yaml

@@ -6,6 +6,9 @@ package:
     The Amazon Corretto Crypto Provider (ACCP) is a collection of high-performance cryptographic implementations exposed via the standard JCA/JCE interfaces.
   copyright:
     - license: Apache-2.0
+  dependencies:
+    runtime:
+      - openjdk-11-jre
 
 environment:
   contents:
@@ -38,6 +41,15 @@ pipeline:
       mkdir -p ${{targets.destdir}}/usr/share/java/amazon-corretto-crypto-provider
       mv build/lib/AmazonCorrettoCryptoProvider.jar ${{targets.destdir}}/usr/share/java/amazon-corretto-crypto-provider/AmazonCorrettoCryptoProvider.jar
 
+test:
+  environment:
+    environment:
+      JAVA_HOME: /usr/lib/jvm/java-11-openjdk
+  pipeline:
+    - name: Verify JAR is not malformed
+      runs: |
+        unzip -l /usr/share/java/amazon-corretto-crypto-provider/AmazonCorrettoCryptoProvider.jar | grep AmazonCorrettoCryptoProvider.class
+
 update:
   enabled: true
   github: