Skip to content
This repository was archived by the owner on Jan 11, 2021. It is now read-only.
This repository was archived by the owner on Jan 11, 2021. It is now read-only.

kube-slack/ignore-pod annotation does not work if you set an empty string as value. #63

@SimonHessel

Description

@SimonHessel

Hi,
I installed kube-slack via the helm chart and tried to use the kube-slack/ignore-pod annotation. Sadly the pods were not ignored, because Javascript returns false if you test for an empty string
if(annotations['kube-slack/ignore-pod'])

Would it be possible to either change this to
if (typeof annotations['kube-slack/ignore-pod'] !== 'undefined')

or update the documentation to specify that you have to add a value.
Maybe I am the only one who got this wrong.
Thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions