Skip to content

Commit 035628d

Browse files
Fix unit tests
1 parent 8967681 commit 035628d

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

WooCommerce/src/test/kotlin/com/woocommerce/android/ui/products/DuplicateProductTest.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.woocommerce.android.ui.products
22

33
import com.woocommerce.android.model.Product
4+
import com.woocommerce.android.model.ProductAggregate
45
import com.woocommerce.android.model.ProductVariation
56
import com.woocommerce.android.ui.products.details.ProductDetailRepository
67
import com.woocommerce.android.ui.products.variations.VariationRepository
@@ -41,9 +42,9 @@ class DuplicateProductTest : BaseUnitTest() {
4142
@Test
4243
fun `should duplicate a product and set expected properties`() = testBlocking {
4344
// given
44-
val productToDuplicate = ProductTestUtils.generateProduct().copy(sku = "not an empty value")
45+
val productToDuplicate = ProductAggregate(ProductTestUtils.generateProduct().copy(sku = "not an empty value"))
4546
productDetailRepository.stub {
46-
onBlocking { addProduct(any()) } doReturn Pair(true, 123)
47+
onBlocking { addProduct(any<ProductAggregate>()) } doReturn Pair(true, 123)
4748
}
4849

4950
// when
@@ -66,10 +67,10 @@ class DuplicateProductTest : BaseUnitTest() {
6667
fun `should duplicate a variable product and keep all properties of variations except sku and remoteProductId`() =
6768
testBlocking {
6869
// given
69-
val productToDuplicate = ProductTestUtils.generateProduct().copy(numVariations = 15)
70+
val productToDuplicate = ProductAggregate(ProductTestUtils.generateProduct().copy(numVariations = 15))
7071
val duplicatedProductId = 456L
7172
productDetailRepository.stub {
72-
onBlocking { addProduct(any()) } doReturn Pair(true, duplicatedProductId)
73+
onBlocking { addProduct(any<ProductAggregate>()) } doReturn Pair(true, duplicatedProductId)
7374
}
7475

7576
val variationsOfProductToDuplicate =

WooCommerce/src/test/kotlin/com/woocommerce/android/ui/products/details/ProductDetailViewModel_AddFlowTest.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ class ProductDetailViewModel_AddFlowTest : BaseUnitTest() {
224224
fun `Display success message on add product success`() = testBlocking {
225225
// given
226226
doReturn(ProductAggregate(product)).whenever(productRepository).getProductAggregate(any())
227-
doReturn(Pair(true, 1L)).whenever(productRepository).addProduct(any())
227+
doReturn(Pair(true, 1L)).whenever(productRepository).addProduct(any<ProductAggregate>())
228228

229229
var successSnackbarShown = false
230230
viewModel.event.observeForever {
@@ -256,7 +256,7 @@ class ProductDetailViewModel_AddFlowTest : BaseUnitTest() {
256256
@Test
257257
fun `Display error message on add product failed`() = testBlocking {
258258
// given
259-
doReturn(Pair(false, 0L)).whenever(productRepository).addProduct(any())
259+
doReturn(Pair(false, 0L)).whenever(productRepository).addProduct(any<ProductAggregate>())
260260

261261
var successSnackbarShown = false
262262
viewModel.event.observeForever {
@@ -310,7 +310,7 @@ class ProductDetailViewModel_AddFlowTest : BaseUnitTest() {
310310
testBlocking {
311311
// given
312312
doReturn(ProductAggregate(product)).whenever(productRepository).getProductAggregate(any())
313-
doReturn(Pair(true, 1L)).whenever(productRepository).addProduct(any())
313+
doReturn(Pair(true, 1L)).whenever(productRepository).addProduct(any<ProductAggregate>())
314314

315315
var successSnackbarShown = false
316316
viewModel.event.observeForever {
@@ -399,7 +399,7 @@ class ProductDetailViewModel_AddFlowTest : BaseUnitTest() {
399399

400400
@Test
401401
fun `when a new product is saved, then assign the new id to ongoing image uploads`() = testBlocking {
402-
doReturn(Pair(true, PRODUCT_REMOTE_ID)).whenever(productRepository).addProduct(any())
402+
doReturn(Pair(true, PRODUCT_REMOTE_ID)).whenever(productRepository).addProduct(any<ProductAggregate>())
403403
doReturn(product).whenever(productRepository).getProductAggregate(any())
404404
savedState = ProductDetailFragmentArgs(
405405
mode = ProductDetailFragment.Mode.AddNewProduct
@@ -454,7 +454,7 @@ class ProductDetailViewModel_AddFlowTest : BaseUnitTest() {
454454
@Test
455455
fun `given a product is under creation, when clicking on save product, then assign uploads to the new id`() =
456456
testBlocking {
457-
doReturn(Pair(true, PRODUCT_REMOTE_ID)).whenever(productRepository).addProduct(any())
457+
doReturn(Pair(true, PRODUCT_REMOTE_ID)).whenever(productRepository).addProduct(any<ProductAggregate>())
458458
doReturn(product).whenever(productRepository).getProductAggregate(any())
459459
viewModel.productDetailViewStateData.observeForever { _, _ -> }
460460

@@ -494,7 +494,7 @@ class ProductDetailViewModel_AddFlowTest : BaseUnitTest() {
494494

495495
@Test
496496
fun `given product status is draft, when save is clicked, then save product with correct status`() = testBlocking {
497-
whenever(productRepository.addProduct(any())).thenAnswer { it.arguments.first() as Product }
497+
whenever(productRepository.addProduct(any<ProductAggregate>())).thenAnswer { it.arguments.first() as Product }
498498
var viewState: ProductDetailViewModel.ProductDetailViewState? = null
499499
viewModel.productDetailViewStateData.observeForever { _, new -> viewState = new }
500500

0 commit comments

Comments
 (0)