Fix customer name display in order filter from order details

Fixed an issue where clicking "View customer orders" from order details showed the customer ID instead of the customer name in the filter view. Implemented a SharedFlow event system in OrderFiltersRepository to trigger the existing onCustomerSelected() logic, which fetches and displays the customer name properly.

Author: kidinov

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/filters/OrderFilterCategoriesViewModel.kt

@@ -91,6 +91,12 @@ class OrderFilterCategoriesViewModel @Inject constructor(
                 savedState[OLD_FILTER_SELECTION_KEY] = oldFilterSelection
             }
         }
+
+        launch {
+            orderFilterRepository.customerSelectedEvent.collect { customer ->
+                onCustomerSelected(customer)
+            }
+        }
     }
 
     fun onFilterCategorySelected(filterCategory: OrderFilterCategoryUiModel) {
@@ -367,12 +373,7 @@ class OrderFilterCategoriesViewModel @Inject constructor(
 
     private suspend fun getCustomerDisplayValueFrom(customerId: Long?): String =
         customerId?.let { id ->
-            orderFilterRepository.customerFilterCustomer?.let { customer ->
-                buildString {
-                    val fullName = "${customer.firstName.orEmpty()} ${customer.lastName.orEmpty()}".trim()
-                    append(fullName.ifBlank { customer.email ?: customer.username.orEmpty() })
-                }
-            } ?: customerStore.getCustomerByRemoteId(selectedSite.get(), id)
+            customerStore.getCustomerByRemoteId(selectedSite.get(), id)
                 ?.let { customer ->
                     (customer.firstName + " " + customer.lastName)
                         .ifBlank { customer.email }

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/filters/data/OrderFiltersRepository.kt

@@ -7,6 +7,9 @@ import com.woocommerce.android.tools.SelectedSite
 import com.woocommerce.android.ui.orders.filters.data.OrderListFilterCategory.CUSTOMER
 import com.woocommerce.android.ui.orders.filters.data.OrderListFilterCategory.PRODUCT
 import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.flow.MutableSharedFlow
+import kotlinx.coroutines.flow.SharedFlow
+import kotlinx.coroutines.flow.asSharedFlow
 import kotlinx.coroutines.flow.distinctUntilChanged
 import kotlinx.coroutines.flow.launchIn
 import kotlinx.coroutines.flow.onEach
@@ -23,15 +26,19 @@ class OrderFiltersRepository @Inject constructor(
 
     var customerFilter: Long? = null
 
-    var customerFilterCustomer: Order.Customer? = null
+    private val _customerSelectedEvent = MutableSharedFlow<Order.Customer>(replay = 0)
+    val customerSelectedEvent: SharedFlow<Order.Customer> = _customerSelectedEvent.asSharedFlow()
+
+    suspend fun selectCustomer(customer: Order.Customer) {
+        _customerSelectedEvent.emit(customer)
+    }
 
     init {
         selectedSite.observe()
             .distinctUntilChanged { old, new -> old?.id == new?.id }
             .onEach {
                 productFilter = null
                 customerFilter = null
-                customerFilterCustomer = null
             }.launchIn(appCoroutineScope)
     }
 

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/list/OrderListFragment.kt

@@ -20,6 +20,7 @@ import androidx.core.view.doOnPreDraw
 import androidx.core.view.isVisible
 import androidx.fragment.app.activityViewModels
 import androidx.fragment.app.viewModels
+import androidx.lifecycle.lifecycleScope
 import androidx.navigation.findNavController
 import androidx.navigation.fragment.NavHostFragment
 import androidx.navigation.fragment.findNavController
@@ -77,6 +78,7 @@ import com.woocommerce.android.util.StringUtils
 import com.woocommerce.android.viewmodel.MultiLiveEvent
 import com.woocommerce.android.widgets.WCEmptyView.EmptyViewType
 import dagger.hilt.android.AndroidEntryPoint
+import kotlinx.coroutines.launch
 import org.wordpress.android.util.ToastUtils
 import javax.inject.Inject
 import org.wordpress.android.util.ActivityUtils as WPActivityUtils
@@ -925,10 +927,9 @@ class OrderListFragment :
 
     fun applyCustomerFilter(customer: Order.Customer) {
         searchQuery = ""
-        val customerId = customer.customerId ?: return
-
-        orderFiltersRepository.customerFilter = customerId
-        orderFiltersRepository.customerFilterCustomer = customer
+        viewLifecycleOwner.lifecycleScope.launch {
+            orderFiltersRepository.selectCustomer(customer)
+        }
         viewModel.loadOrders()
 
         uiMessageResolver.showSnack(R.string.order_list_customer_filter_applied)