Add logging to ConnectionManager disconnect error handling

Author: kidinov

libs/cardreader/src/main/java/com/woocommerce/android/cardreader/CardReaderManagerFactory.kt

@@ -77,6 +77,7 @@ object CardReaderManagerFactory {
                 DiscoverReadersAction(terminal, logWrapper),
                 terminalListener,
                 application,
+                logWrapper,
             ),
             SoftwareUpdateManager(
                 terminal,

libs/cardreader/src/main/java/com/woocommerce/android/cardreader/internal/connection/ConnectionManager.kt

@@ -12,6 +12,7 @@ import com.stripe.stripeterminal.external.models.Reader
 import com.stripe.stripeterminal.external.models.TerminalErrorCode
 import com.stripe.stripeterminal.external.models.TerminalException
 import com.woocommerce.android.cardreader.CardReaderManager
+import com.woocommerce.android.cardreader.LogWrapper
 import com.woocommerce.android.cardreader.connection.CardReader
 import com.woocommerce.android.cardreader.connection.CardReaderDiscoveryEvents
 import com.woocommerce.android.cardreader.connection.CardReaderImpl
@@ -33,14 +34,17 @@ import kotlinx.coroutines.flow.merge
 import kotlinx.coroutines.launch
 
 private const val ARTIFICIAL_STATUS_UPDATE_DELAY_IN_MILLIS = 500L
+private const val LOG_TAG = "ConnectionManager"
 
+@Suppress("LongParameterList")
 internal class ConnectionManager(
     private val terminal: TerminalWrapper,
     private val bluetoothReaderListener: BluetoothReaderListenerImpl,
     private val tapToPayReaderListener: TapToPayReaderListenerImpl,
     private val discoverReadersAction: DiscoverReadersAction,
     private val terminalListenerImpl: TerminalListenerImpl,
     private val application: Application,
+    private val logWrapper: LogWrapper,
 ) {
     val softwareUpdateStatus = bluetoothReaderListener.updateStatusEvents
     val softwareUpdateAvailability = bluetoothReaderListener.updateAvailabilityEvents
@@ -146,7 +150,8 @@ internal class ConnectionManager(
             terminal.disconnectReader()
             updateReaderStatus(CardReaderStatus.NotConnected())
             true
-        } catch (@Suppress("SwallowedException") e: TerminalException) {
+        } catch (e: TerminalException) {
+            logWrapper.e(LOG_TAG, "Failed to disconnect reader: ${e.errorMessage}")
             updateReaderStatus(CardReaderStatus.NotConnected())
             false
         }

libs/cardreader/src/test/java/com/woocommerce/android/cardreader/internal/connection/ConnectionManagerTest.kt

@@ -5,6 +5,7 @@ import com.stripe.stripeterminal.external.models.DeviceType
 import com.stripe.stripeterminal.external.models.Reader
 import com.stripe.stripeterminal.external.models.TerminalErrorCode
 import com.stripe.stripeterminal.external.models.TerminalException
+import com.woocommerce.android.cardreader.LogWrapper
 import com.woocommerce.android.cardreader.connection.CardReaderDiscoveryEvents
 import com.woocommerce.android.cardreader.connection.CardReaderDiscoveryEvents.ReadersFound
 import com.woocommerce.android.cardreader.connection.CardReaderImpl
@@ -45,6 +46,7 @@ class ConnectionManagerTest : CardReaderBaseUnitTest() {
         on { readerStatus }.thenReturn(MutableStateFlow(CardReaderStatus.NotConnected()))
     }
     private val application: Application = mock()
+    private val logWrapper: LogWrapper = mock()
 
     private val supportedReaders =
         CardReaderTypesToDiscover.SpecificReaders.ExternalReaders(
@@ -65,6 +67,7 @@ class ConnectionManagerTest : CardReaderBaseUnitTest() {
             discoverReadersAction,
             terminalListenerImpl,
             application,
+            logWrapper,
         )
     }