Merge pull request #14592 from woocommerce/migrate/wc-new-visitor-stats-model-to-room

[WellSQL Migration] Migrate `WCNewVisitorStatsModel` to Room

Author: ParaskP7

WooCommerce-Wear/src/main/java/com/woocommerce/android/wear/ui/stats/datasource/StatsRepository.kt

@@ -101,7 +101,6 @@ class StatsRepository @Inject constructor(
                 result.granularity,
                 result.quantity,
                 result.date,
-                result.isCustomField
             ).let {
                 Result.success(it.values.sum())
             }

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/dashboard/data/StatsRepository.kt

@@ -154,7 +154,6 @@ class StatsRepository @Inject constructor(
                     result.granularity,
                     result.quantity,
                     result.date,
-                    result.isCustomField
                 )
             }
             Result.success(visitorStats)

WooCommerce/src/test/kotlin/com/woocommerce/android/ui/dashboard/data/StatsRepositoryTests.kt

@@ -68,12 +68,12 @@ class StatsRepositoryTests : BaseUnitTest() {
     fun `when visitors and revenue requests succeed then a success response is returned containing both value`() =
         testBlocking {
             val granularity = WCStatsStore.StatsGranularity.DAYS
+            val quantity = "5"
             val startDate = "2024-01-25 00:00:00"
             val endDate = "2024-01-25 23:59:59"
             val visitorStatsResponse = WCStatsStore.OnWCStatsChanged(
-                rowsAffected = 2,
                 granularity = granularity,
-                quantity = "5",
+                quantity = quantity,
                 date = startDate
             )
 
@@ -87,6 +87,8 @@ class StatsRepositoryTests : BaseUnitTest() {
             whenever(selectedSite.get()).thenReturn(defaultSiteModel)
             whenever(wooCommerceStore.getSiteSettings(any())).thenReturn(null)
             whenever(wcStatsStore.fetchNewVisitorStats(any())).thenReturn(visitorStatsResponse)
+            whenever(wcStatsStore.getNewVisitorStats(defaultSiteModel, granularity, quantity, startDate))
+                .thenReturn(emptyMap())
             whenever(wcStatsStore.fetchRevenueStats(any())).thenReturn(revenueStatsResponse)
             whenever(wcStatsStore.getRawRevenueStats(eq(defaultSiteModel), eq(granularity), eq(startDate), eq(endDate)))
                 .thenReturn(WCRevenueStatsModel())
@@ -111,7 +113,7 @@ class StatsRepositoryTests : BaseUnitTest() {
         val granularity = WCStatsStore.StatsGranularity.DAYS
         val startDate = "2024-01-25 00:00:00"
         val endDate = "2024-01-25 23:59:59"
-        val visitorStatsResponse = WCStatsStore.OnWCStatsChanged(0, granularity).also {
+        val visitorStatsResponse = WCStatsStore.OnWCStatsChanged(granularity).also {
             it.error = WCStatsStore.OrderStatsError()
             it.causeOfChange = WCStatsAction.FETCH_NEW_VISITOR_STATS
         }
@@ -150,7 +152,6 @@ class StatsRepositoryTests : BaseUnitTest() {
         val granularity = WCStatsStore.StatsGranularity.DAYS
         val startDate = "2024-01-25 00:00:00"
         val visitorStatsResponse = WCStatsStore.OnWCStatsChanged(
-            rowsAffected = 2,
             granularity = granularity,
             quantity = "5",
             date = startDate

config/detekt/baseline.xml

@@ -2271,21 +2271,6 @@
     <ID>UnitTestNamingRule:WCShippingLabelStoreTest.kt$WCShippingLabelStoreTest$@Test fun `verify shipping address`()</ID>
     <ID>UnitTestNamingRule:WCStatsSqlUtilsTest.kt$WCStatsSqlUtilsTest$@Test @Suppress("LongMethod") fun testGetRawRevenueStatsForSiteAndUnit()</ID>
     <ID>UnitTestNamingRule:WCStatsSqlUtilsTest.kt$WCStatsSqlUtilsTest$@Test @Suppress("LongMethod") fun testSimpleInsertionAndRetrievalOfRevenueStats()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Suppress("LongMethod") @Test fun testGetQuantityForMonths()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Suppress("LongMethod") @Test fun testGetQuantityForWeeks()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Suppress("LongMethod") @Test fun testGetQuantityForYears()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Test @Suppress("LongMethod") fun testGetRevenueAndOrderStatsForSite()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Test @Suppress("LongMethod") fun testGetVisitorStatsForCurrentDayGranularity()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Test @Suppress("LongMethod") fun testGetVisitorStatsForThisWeekGranularity()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Test fun testFailedFetchingVisitorSummaryStats()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Test fun testFetchBundlesErrorResponse()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Test fun testFetchBundlesNullResponse()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Test fun testFetchBundlesSuccessResponse()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Test fun testFetchCurrentDayRevenueStatsDate()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Test fun testFetchCurrentDayRevenueStatsDateSpecificEndDate()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Test fun testGetNewVisitorStatsWithInvalidData()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Test fun testGetQuantityForDays()</ID>
-    <ID>UnitTestNamingRule:WCStatsStoreTest.kt$WCStatsStoreTest$@Test fun testSuccessfulFetchingVisitorSummaryStats()</ID>
     <ID>UnitTestNamingRule:WCTaxStoreTest.kt$WCTaxStoreTest$@Test fun `get stored tax class list for site`()</ID>
     <ID>UnitTestNamingRule:WCUserStoreTest.kt$WCUserStoreTest$@Test fun `fetch user role`()</ID>
     <ID>UnitTestNamingRule:WCUserStoreTest.kt$WCUserStoreTest$@Test fun `get user role from db`()</ID>