Merge pull request #14907 from woocommerce/woomob-1638-beta-236-local-catalog-splash-screen-shown-even-for-non

[Woo POS][Local Catalog][Beta 23.6] Do not show "Local Catalog syncing" state if local catalog is disabled

Author: samiuelson

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/products/WooPosProductsDataSource.kt

@@ -57,8 +57,6 @@ class WooPosProductsDataSource @Inject constructor(
     private var activeSource: WooPosProductsDataSourceInterface? = null
 
     fun prepopulateCache(): Flow<WooPosPrepopulatingDataStatus> = flow {
-        emit(WooPosPrepopulatingDataStatus.Syncing)
-
         val requirement = syncStatusChecker.checkSyncRequirement()
         when (requirement) {
             is WooPosFullSyncRequirement.LocalCatalogDisabled -> {
@@ -80,6 +78,7 @@ class WooPosProductsDataSource @Inject constructor(
             }
 
             is WooPosFullSyncRequirement.BlockingRequired -> {
+                emit(WooPosPrepopulatingDataStatus.Syncing)
                 activeSource = localDbDataSource
                 localDbDataSource.prepopulateCache().fold(
                     onSuccess = {