Fix status bar insets in WooPos Orders screens

- Remove global `statusBarsPadding` from the root `WooPosOrdersScreen` container.
- Apply `statusBarsPadding` individually to `OrdersContent`, `OrdersEmpty`, `OrdersError`, and `WooPosToolbar`.
- Add `statusBarsPadding` to `WooPosOrdersDetails`.
- Refactor `WooPosOrdersLoadingScreen` layout to correctly handle status bar insets and toolbar spacing.

Author: samiuelson

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersDetails.kt

@@ -9,6 +9,7 @@ import androidx.compose.foundation.layout.height
 import androidx.compose.foundation.layout.heightIn
 import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.layout.size
+import androidx.compose.foundation.layout.statusBarsPadding
 import androidx.compose.foundation.rememberScrollState
 import androidx.compose.foundation.shape.RoundedCornerShape
 import androidx.compose.foundation.verticalScroll
@@ -46,6 +47,7 @@ fun WooPosOrderDetails(
     Column(
         modifier = modifier
             .fillMaxSize()
+            .statusBarsPadding()
             .verticalScroll(rememberScrollState())
             .padding(
                 start = WooPosSpacing.Medium.value,

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersLoadingScreen.kt

@@ -13,6 +13,7 @@ import androidx.compose.foundation.layout.height
 import androidx.compose.foundation.layout.heightIn
 import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.layout.size
+import androidx.compose.foundation.layout.statusBarsPadding
 import androidx.compose.foundation.layout.width
 import androidx.compose.foundation.lazy.LazyColumn
 import androidx.compose.foundation.shape.RoundedCornerShape
@@ -40,14 +41,15 @@ import com.woocommerce.android.ui.woopos.common.composeui.designsystem.WooPosThe
 import com.woocommerce.android.ui.woopos.common.composeui.designsystem.WooPosTypography
 
 @Composable
-fun WooPosOrdersLoadingScreen() {
-    Row(modifier = Modifier.fillMaxSize()) {
+fun WooPosOrdersLoadingScreen(modifier: Modifier = Modifier) {
+    Row(
+        modifier = modifier.fillMaxSize()
+    ) {
         WooPosOrdersListLoadingPane(
             modifier = Modifier
                 .weight(0.3f)
                 .fillMaxHeight()
                 .background(MaterialTheme.colorScheme.surfaceBright)
-                .padding(top = WOO_POS_ORDERS_TOOLBAR_HEIGHT)
         )
 
         OrderDetailsLoadingPane(
@@ -109,13 +111,17 @@ fun WooPosOrdersOrderLoadingRow() {
 
 @Composable
 fun WooPosOrdersListLoadingPane(modifier: Modifier = Modifier) {
-    LazyColumn(
-        modifier = modifier,
-        verticalArrangement = Arrangement.spacedBy(WooPosSpacing.Medium.value),
-        contentPadding = PaddingValues(WooPosSpacing.Medium.value)
-    ) {
-        items(7) {
-            WooPosOrdersOrderLoadingRow()
+    Column(modifier = modifier.statusBarsPadding()) {
+        Spacer(modifier = Modifier.height(WOO_POS_ORDERS_TOOLBAR_HEIGHT))
+
+        LazyColumn(
+            modifier = Modifier.fillMaxSize(),
+            verticalArrangement = Arrangement.spacedBy(WooPosSpacing.Medium.value),
+            contentPadding = PaddingValues(WooPosSpacing.Medium.value)
+        ) {
+            items(7) {
+                WooPosOrdersOrderLoadingRow()
+            }
         }
     }
 }
@@ -125,6 +131,7 @@ private fun OrderDetailsLoadingPane(modifier: Modifier = Modifier) {
     Column(
         modifier = modifier
             .fillMaxSize()
+            .statusBarsPadding()
             .padding(horizontal = WooPosSpacing.Medium.value)
     ) {
         Row(

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersScreen.kt

@@ -133,7 +133,6 @@ private fun WooPosOrdersScreen(
     Box(
         modifier = Modifier
             .fillMaxSize()
-            .statusBarsPadding()
     ) {
         when (state) {
             is WooPosOrdersState.Content -> OrdersContent(
@@ -149,11 +148,13 @@ private fun WooPosOrdersScreen(
             )
 
             is WooPosOrdersState.Empty -> OrdersEmpty(
-                onActionClicked = onOrdersEmptyActionClicked
+                onActionClicked = onOrdersEmptyActionClicked,
+                modifier = Modifier.statusBarsPadding()
             )
 
             is WooPosOrdersState.Error -> OrdersError(
-                onRetryClicked = onOrdersLoadingErrorRetryButtonClicked
+                onRetryClicked = onOrdersLoadingErrorRetryButtonClicked,
+                modifier = Modifier.statusBarsPadding()
             )
 
             is WooPosOrdersState.Loading -> WooPosOrdersLoadingScreen()
@@ -163,7 +164,9 @@ private fun WooPosOrdersScreen(
             WooPosToolbar(
                 titleText = stringResource(R.string.woopos_orders_title),
                 onBackClicked = onBackClicked,
-                modifier = Modifier.fillMaxWidth()
+                modifier = Modifier
+                    .fillMaxWidth()
+                    .statusBarsPadding()
             )
         }
     }
@@ -227,7 +230,9 @@ private fun OrdersListPane(
     onSearchErrorRetry: () -> Unit,
     modifier: Modifier = Modifier
 ) {
-    Column(modifier = modifier) {
+    Column(
+        modifier = modifier.statusBarsPadding()
+    ) {
         Box(
             modifier = Modifier
                 .fillMaxWidth()
@@ -467,10 +472,11 @@ private fun LoadedOrdersList(
 
 @Composable
 private fun OrdersEmpty(
-    onActionClicked: () -> Unit
+    onActionClicked: () -> Unit,
+    modifier: Modifier = Modifier
 ) {
     WooPosEmptyScreen(
-        modifier = Modifier.fillMaxSize(),
+        modifier = modifier.fillMaxSize(),
         icon = WooPosIcons.OrdersEmpty,
         title = stringResource(id = R.string.woopos_orders_empty_list_title),
         message = stringResource(id = R.string.woopos_orders_empty_list_message),
@@ -482,9 +488,11 @@ private fun OrdersEmpty(
 
 @Composable
 private fun OrdersError(
-    onRetryClicked: () -> Unit
+    onRetryClicked: () -> Unit,
+    modifier: Modifier = Modifier
 ) {
     WooPosErrorScreen(
+        modifier = modifier,
         message = stringResource(id = R.string.woopos_orders_loading_error_title),
         reason = stringResource(id = R.string.woopos_orders_loading_error_message),
         primaryButton = WooPosErrorScreenButtonState(