Skip to content

Commit 9a935d0

Browse files
committed
Stop jumping
1 parent 8064f03 commit 9a935d0

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersLoadingScreen.kt

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package com.woocommerce.android.ui.woopos.orders
22

33
import androidx.compose.foundation.background
44
import androidx.compose.foundation.layout.Arrangement
5+
import androidx.compose.foundation.layout.Box
56
import androidx.compose.foundation.layout.Column
67
import androidx.compose.foundation.layout.PaddingValues
78
import androidx.compose.foundation.layout.Row
@@ -112,7 +113,7 @@ fun WooPosOrdersOrderLoadingRow() {
112113
@Composable
113114
fun WooPosOrdersListLoadingPane(modifier: Modifier = Modifier) {
114115
Column(modifier = modifier.statusBarsPadding()) {
115-
Spacer(modifier = Modifier.height(WOO_POS_ORDERS_TOOLBAR_HEIGHT))
116+
Spacer(modifier = Modifier.height(WOO_POS_ORDERS_TOOLBAR_HEIGHT + WooPosSpacing.Small.value))
116117

117118
LazyColumn(
118119
modifier = Modifier.fillMaxSize(),
@@ -140,22 +141,22 @@ private fun OrderDetailsLoadingPane(modifier: Modifier = Modifier) {
140141
horizontalArrangement = Arrangement.SpaceBetween
141142
) {
142143
Column {
143-
Spacer(modifier = Modifier.height(WooPosSpacing.Small.value))
144-
145-
WooPosShimmerText(
146-
text = "Order #123",
147-
style = WooPosTypography.Heading.style,
148-
fontWeight = FontWeight.Bold
149-
)
144+
Box(Modifier.height(WOO_POS_ORDERS_TOOLBAR_HEIGHT), contentAlignment = Alignment.Center) {
145+
WooPosShimmerText(
146+
text = "Order #123",
147+
style = WooPosTypography.Heading.style,
148+
fontWeight = FontWeight.Bold
149+
)
150+
}
150151

151-
Spacer(modifier = Modifier.height(WooPosSpacing.Medium.value))
152+
Spacer(modifier = Modifier.height(WooPosSpacing.Small.value))
152153

153154
WooPosShimmerText(
154155
text = "Jul 28, 2025 at 10:31 PM",
155156
style = WooPosTypography.BodyMedium.style
156157
)
157158

158-
Spacer(modifier = Modifier.height(WooPosSpacing.Small.value))
159+
Spacer(modifier = Modifier.height(WooPosSpacing.Medium.value))
159160

160161
WooPosShimmerText(
161162
text = "Completed",
@@ -165,6 +166,7 @@ private fun OrderDetailsLoadingPane(modifier: Modifier = Modifier) {
165166

166167
WooPosShimmerBox(
167168
modifier = Modifier
169+
.padding(vertical = WooPosSpacing.Small.value)
168170
.width(140.dp)
169171
.height(36.dp)
170172
.clip(RoundedCornerShape(WooPosCornerRadius.Small.value))
@@ -185,7 +187,7 @@ private fun OrderDetailsLoadingPane(modifier: Modifier = Modifier) {
185187
text = stringResource(R.string.woopos_orders_details_products_title),
186188
style = WooPosTypography.BodyXLarge,
187189
color = MaterialTheme.colorScheme.onSurface,
188-
fontWeight = FontWeight.Bold
190+
fontWeight = FontWeight.SemiBold
189191
)
190192

191193
Spacer(modifier = Modifier.height(WooPosSpacing.Medium.value))
@@ -215,7 +217,7 @@ private fun OrderDetailsLoadingPane(modifier: Modifier = Modifier) {
215217
text = stringResource(R.string.woopos_orders_details_totals_title),
216218
style = WooPosTypography.BodyXLarge,
217219
color = MaterialTheme.colorScheme.onSurface,
218-
fontWeight = FontWeight.Bold
220+
fontWeight = FontWeight.SemiBold
219221
)
220222

221223
Spacer(modifier = Modifier.height(WooPosSpacing.Medium.value))

0 commit comments

Comments
 (0)